Problem/Motivation

When testing locally, both composer require drupal/color-color and composer require drupal/color work for me.

The project page still mentions color-color, but according to mixologic here: https://drupal.slack.com/archives/C014CT1CN1M/p1658898729516069, that should be a thing of the past.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 2.diff394 bytesspokje

Issue fork color-3303051

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Spokje created an issue. See original summary.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Priority: Normal » Critical

I think this is critical now:

$ composer show drupal/color
name     : drupal/color
...

$ composer show drupal/color-color

In ShowCommand.php line 277:
                                                                                                
  Package "drupal/color-color" not found, try using --all (-a) to show all available packages.
spokje’s picture

spokje
Primary language Dutch
commented

Weirdly, for me drupal/color-color still exists, even after a composer cache clear:

$ composer cc
Clearing cache (cache-vcs-dir):
Clearing cache (cache-repo-dir): 
Clearing cache (cache-files-dir):
Clearing cache (cache-dir): 
All caches cleared.

$ composer show drupal/color-color
name     : drupal/color-color
descrip. :
keywords :
versions : * 1.0.1
type     : drupal-module
license  : GNU General Public License v2.0 or later (GPL-2.0-or-later) (OSI approved) https://spdx.org/licenses/GPL-2.0-or-later.html#licenseText
homepage : https://www.drupal.org/project/color
source   : [git] https://git.drupalcode.org/project/color.git 1.0.1
dist     : [zip] https://ftp.drupal.org/files/projects/color-1.0.1.zip 1.0.1
path     : D:\htdocs\drupal\modules\contrib\color-color
names    : drupal/color-color

support
source : https://git.drupalcode.org/project/color

requires
drupal/core >=9.4

Spokje opened merge request !2

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new 2.diff394 bytes

Looking at the previous fail using an MR in #3302976: Port remaining changes from core, let's do the same as we did in there and test the plain diff as a patch as well.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Needs review

Well, the MR passing by itself is a pleasant surprise and I think it firmly points the MR test-failure in the other issue is caused by drupal/color-color.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

The passing MR is indeed encouraging, so marking this RTBC.

  • andypost committed 058392f on 1.x authored by Spokje 
    Issue #3303051 by Spokje: drupal/color-color can be changed to drupal/...
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Fixed

Thank, gonna commit #3302976: Port remaining changes from core

andypost’s picture

andypost
he/him
Primary language Russian
commented

MR could be closed, sorry missed it

Spokje closed merge request !2

sah62’s picture

sah62 commented

Are you sure this is fixed? I just did the following:

Put my site into maintenance mode
Uninstalled the backported color module
Removed drupal/color-color using composer
Installed drupal/color using composer
Enabled the color module
Tried to take the site out of maintenance mode, and bam! The site crashes and there are three errors in my log:

Warning: include(/var/www/mysite/web/modules/contrib/color-color/src/EventSubscriber/ColorConfigCacheInvalidator.php): failed to open stream: No such file or directory in include() (line 571 of /var/www/mysite/vendor/composer/ClassLoader.php)

Warning: include(): Failed opening '/var/www/mysite/web/modules/contrib/color-color/src/EventSubscriber/ColorConfigCacheInvalidator.php' for inclusion (include_path='/var/www/mysite/vendor/pear/archive_tar:/var/www/mysite/vendor/pear/console_getopt:/var/www/mysite/vendor/pear/pear-core-minimal/src:/var/www/mysite/vendor/pear/pear_exception:.:/usr/share/php') in include() (line 571 of /var/www/mysite/vendor/composer/ClassLoader.php)

Error: Class 'Drupal\color\EventSubscriber\ColorConfigCacheInvalidator' not found in Drupal\Component\DependencyInjection\Container->createService() (line 262 of /var/www/mysite/web/core/lib/Drupal/Component/DependencyInjection/Container.php)

Did I do something wrong, or is something still broken here? If I reinstall drupal/color-color (along with drupal/color) it all works again

andypost’s picture

andypost
he/him
Primary language Russian
commented

That's strange, just used to composer require drupal/color and it used to install it into modules/custom/color

sah62’s picture

sah62 commented

I have both color and color-color installed by composer in modules/contrib. When I tried color by itself I get the errors described above.

andypost’s picture

andypost
he/him
Primary language Russian
commented

sadly I can't reproduce it

could you remove both and require drupal/color?

sah62’s picture

sah62 commented

Done, running with just drupal/color. I'm still getting the errors when I try to move to a page that displays a page with color configured, like my web site's home page. The same errors appear when I try to save the configuration for my color-enabled theme, Bartik. Here's the call stack for the first error:

Warning: include(/var/www/mysite/web/modules/contrib/color-color/src/ColorSystemBrandingBlockAlter.php): failed to open stream: No such file or directory in include() (line 571 of /var/www/mysite/vendor/composer/ClassLoader.php)
#0 /var/www/mysite/web/core/includes/bootstrap.inc(347): _drupal_error_handler_real()
#1 /var/www/mysite/vendor/composer/ClassLoader.php(571): _drupal_error_handler()
#2 /var/www/mysite/vendor/composer/ClassLoader.php(571): include()
#3 /var/www/mysite/vendor/composer/ClassLoader.php(mysite): Composer\Autoload\includeFile()
#4 [internal function]: Composer\Autoload\ClassLoader->loadClass()
#5 /var/www/mysite/web/core/lib/Drupal/Core/Security/DoTrustedCallbackTrait.php(51): spl_autoload_call()
#6 /var/www/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(772): Drupal\Core\Render\Renderer->doTrustedCallback()
#7 /var/www/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(363): Drupal\Core\Render\Renderer->doCallback()
#8 /var/www/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(435): Drupal\Core\Render\Renderer->doRender()
#9 /var/www/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(201): Drupal\Core\Render\Renderer->doRender()
#10 /var/www/mysite/web/core/lib/Drupal/Core/Template/TwigExtension.php(479): Drupal\Core\Render\Renderer->render()
#11 /var/www/mysite/web/sites/default/files/php/twig/630015aad7c15_page.html.twig_jsREMVN6xVNOB8wzBpXBEpby3/bfoa8vKZYFNk6wiYzIybzhVshVSAIAbFLzb0kp7lHeA.php(49): Drupal\Core\Template\TwigExtension->escapeFilter()
#12 /var/www/mysite/vendor/twig/twig/src/Template.php(405): __TwigTemplate_d9fcad918860c4a941168246607ecf2175dd1616b18e377019e7e059d38d959f->doDisplay()
#13 /var/www/mysite/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling()
#14 /var/www/mysite/vendor/twig/twig/src/Template.php(390): Twig\Template->display()
#15 /var/www/mysite/web/core/themes/engines/twig/twig.engine(55): Twig\Template->render()
#16 /var/www/mysite/web/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template()
#17 /var/www/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(422): Drupal\Core\Theme\ThemeManager->render()
#18 /var/www/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(201): Drupal\Core\Render\Renderer->doRender()
#19 /var/www/mysite/web/core/lib/Drupal/Core/Template/TwigExtension.php(479): Drupal\Core\Render\Renderer->render()
#20 /var/www/mysite/web/sites/default/files/php/twig/630015aad7c15_html.html.twig_Ew13XxPJddyGBIisgZBPX0leX/8pw96lAQA08w01WDolllSIWTNx9n9Pmi89C3Ho9pdNY.php(86): Drupal\Core\Template\TwigExtension->escapeFilter()
#21 /var/www/mysite/vendor/twig/twig/src/Template.php(405): __TwigTemplate_c0df9a44a5e29ffb231e87b92ab1baa7497e28eec81e01cdce13112a19e90fa5->doDisplay()
#22 /var/www/mysite/vendor/twig/twig/src/Template.php(378): Twig\Template->displayWithErrorHandling()
#23 /var/www/mysite/vendor/twig/twig/src/Template.php(390): Twig\Template->display()
#24 /var/www/mysite/web/core/themes/engines/twig/twig.engine(55): Twig\Template->render()
#25 /var/www/mysite/web/core/lib/Drupal/Core/Theme/ThemeManager.php(384): twig_render_template()
#26 /var/www/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(422): Drupal\Core\Theme\ThemeManager->render()
#27 /var/www/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(201): Drupal\Core\Render\Renderer->doRender()
#28 /var/www/mysite/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(162): Drupal\Core\Render\Renderer->render()
#29 /var/www/mysite/web/core/lib/Drupal/Core/Render/Renderer.php(564): Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}()
#30 /var/www/mysite/web/core/lib/Drupal/Core/Render/MainContent/HtmlRenderer.php(163): Drupal\Core\Render\Renderer->executeInRenderContext()
#31 /var/www/mysite/web/core/lib/Drupal/Core/EventSubscriber/MainContentViewSubscriber.php(90): Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse()
#32 [internal function]: Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray()
#33 /var/www/mysite/web/core/lib/Drupal/Component/EventDispatcher/ContainerAwareEventDispatcher.php(142): call_user_func()
#34 /var/www/mysite/vendor/symfony/http-kernel/HttpKernel.php(163): Drupal\Component\EventDispatcher\ContainerAwareEventDispatcher->dispatch()
#35 /var/www/mysite/vendor/symfony/http-kernel/HttpKernel.php(80): Symfony\Component\HttpKernel\HttpKernel->handleRaw()
#36 /var/www/mysite/web/core/lib/Drupal/Core/StackMiddleware/Session.php(58): Symfony\Component\HttpKernel\HttpKernel->handle()
#37 /var/www/mysite/web/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(48): Drupal\Core\StackMiddleware\Session->handle()
#38 /var/www/mysite/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(106): Drupal\Core\StackMiddleware\KernelPreHandle->handle()
#39 /var/www/mysite/web/core/modules/page_cache/src/StackMiddleware/PageCache.php(85): Drupal\page_cache\StackMiddleware\PageCache->pass()
#40 /var/www/mysite/web/modules/contrib/cleantalk/src/EventSubscriber/BootSubscriber.php(320): Drupal\page_cache\StackMiddleware\PageCache->handle()
#41 /var/www/mysite/web/core/modules/ban/src/BanMiddleware.php(50): Drupal\cleantalk\EventSubscriber\BootSubscriber->handle()
#42 /var/www/mysite/web/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(48): Drupal\ban\BanMiddleware->handle()
#43 /var/www/mysite/web/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(51): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle()
#44 /var/www/mysite/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle()
#45 /var/www/mysite/web/core/lib/Drupal/Core/DrupalKernel.php(709): Stack\StackedHttpKernel->handle()
#46 /var/www/mysite/web/index.php(19): Drupal\Core\DrupalKernel->handle()
#47 {main}

I've cleared my composer cache and flushed caches with drush. Did I miss something?

andypost’s picture

andypost
he/him
Primary language Russian
commented

web/modules/contrib/color-color/src/ColorSystemBrandingBlockAlter.php): failed to open stream: No such file or directory in include() (line 571 of /var/www/mysite/vendor/composer/ClassLoader.php)

which means that composer's cassloader still looking into "color-color" for some reason, very probably the issue is because opcache or apcu caching code so you need to reload php-fpm (pkill -USR2 php-fpm)

sah62’s picture

sah62 commented

That did the trick - thank you!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.