Problem/Motivation

Since this module was copied from core some commits have been made to the core/modules/color directory.

Steps to reproduce

$ composer require drupal/color
$ diff -urp web/core/modules/color web/modules/contrib/color

Proposed resolution

Remaining tasks

Figure out which commits should be ported.

#3281430: Update non-migration Color tests to not use Bartik is an obvious candidate.

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 1.diff17.46 KBspokje

Issue fork color-3302976

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

andypost’s picture

andypost
he/him
Primary language Russian
commented

I bet main question is bartik/seven clean-up, but how to cut it or recreate 1.0.x

spokje’s picture

spokje
Primary language Dutch
commented

@dww struggled/struggles with the same for the contrib quickedit module.

Here are some Slack threads how he's handling/handled it so far:

https://drupal.slack.com/archives/C014CT1CN1M/p1655854191324579
https://drupal.slack.com/archives/C014CT1CN1M/p1647369591338049

Hope it helps, seems this is the final blocker for #3270899: Remove Color module from core

bbrala made their first commit to this issue’s fork.

bbrala opened merge request !1

bbrala’s picture

bbrala
Location Netherlands
commented
Status: Active » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
commented

Thanks 👍

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Looks OK to me. Remaining diffs between contrib and core are:

  • ES6 is used in core but not contrib
  • @group legacy is removed from contrib tests
  • A small number of typehints are not present in contrib (maybe this is PHP version related?)
spokje’s picture

spokje
Primary language Dutch
commented
Status: Reviewed & tested by the community » Active
StatusFileSize
new 1.diff17.46 KB

Let's see if uploading the plain diff from MR!1 eliminates the "weird" composer failure from the MR test.

spokje’s picture

spokje
Primary language Dutch
commented
Status: Active » Reviewed & tested by the community

Unwanted status change

spokje’s picture

spokje
Primary language Dutch
commented

MR test-failure _might_ be related to #3303051: drupal/color-color can be changed to drupal/color?

In any case: The plain diff from the MR passes tests on both 9.4.x and 10.0.x, so I'm fine with the RTBC state as declared by @longwave.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Yep I think so, drupal/color-color no longer exists for me.

  • andypost committed 365c515 on 1.x authored by bbrala 
    Issue #3302976 by bbrala, Spokje, longwave: Port remaining changes from...
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.