$ phpcs --standard=Drupalpractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml string/
Xdebug: [Step Debug] Time-out connecting to debugging client, waited: 200 ms. Tried: localhost:9000 (through xdebug.client_host/xdebug.client_port) :-(

FILE: C:\Users\SI-001\Downloads\string\modules\string_tmgmt\src\Plugin\tmgmt\Source\StringSource.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
23 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\Users\SI-001\Downloads\string\src\Form\ExportForm.php
------------------------------------------------------------------------------------------------------------------------------------------
90 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------

Issue fork string-3302369

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Rakhi Soni created an issue. See original summary.

rakhi soni’s picture

Assigned: rakhi soni » Unassigned
Status: Active » Needs review
StatusFileSize
new1.97 KB

Kindly review patch,,

sourabhjain’s picture

Assigned: Unassigned » sourabhjain

I will review it.

sourabhjain’s picture

Assigned: sourabhjain » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new909.19 KB
new1.25 MB

I have reviewed the patch #2 and found that there are other DrupalPractice issues are also available but assuming in this ticket only t() is fixed and that is fixed, I have checked it and attaching screenshots for reference.
Moving to RTBC.

SolimanHarkas made their first commit to this issue’s fork.

solimanharkas’s picture

Thank you, the problem with t() function is fixed now. merged to branch 1.0.x

d34dman’s picture

Status: Reviewed & tested by the community » Fixed
Issue tags: -

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.