$ phpcs --standard=Drupalpractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml string/
Xdebug: [Step Debug] Time-out connecting to debugging client, waited: 200 ms. Tried: localhost:9000 (through xdebug.client_host/xdebug.client_port) :-(
FILE: C:\Users\SI-001\Downloads\string\modules\string_tmgmt\src\Plugin\tmgmt\Source\StringSource.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
23 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------
FILE: C:\Users\SI-001\Downloads\string\src\Form\ExportForm.php
------------------------------------------------------------------------------------------------------------------------------------------
90 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
------------------------------------------------------------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | after-patch.png | 1.25 MB | sourabhjain |
| #4 | before-patch.png | 909.19 KB | sourabhjain |
| #2 | t-calls-should-be-avoided-3302369-2.patch | 1.97 KB | rakhi soni |
Issue fork string-3302369
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
rakhi soni commentedKindly review patch,,
Comment #3
sourabhjainI will review it.
Comment #4
sourabhjainI have reviewed the patch #2 and found that there are other DrupalPractice issues are also available but assuming in this ticket only t() is fixed and that is fixed, I have checked it and attaching screenshots for reference.
Moving to RTBC.
Comment #8
solimanharkas commentedThank you, the problem with t() function is fixed now. merged to branch 1.0.x
Comment #9
d34dman commented