$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml ultimenu/
Xdebug: [Step Debug] Time-out connecting to debugging client, waited: 200 ms. Tried: localhost:9000 (through xdebug.client_host/xdebug.client_port) :-(
FILE: C:\Users\SI-001\Downloads\tagclouds\ultimenu\src\Plugin\Block\UltimenuBlock.php
-------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------
132 | ERROR | [x] Use null coalesce operator instead of ternary operator.
280 | ERROR | [x] list(...) is forbidden, use [...] instead.
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------
FILE: C:\Users\SI-001\Downloads\tagclouds\ultimenu\src\UltimenuManager.php
---------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------
449 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------
FILE: C:\Users\SI-001\Downloads\tagclouds\ultimenu\src\UltimenuSkin.php
---------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------
95 | ERROR | [x] list(...) is forbidden, use [...] instead.
110 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------
FILE: C:\Users\SI-001\Downloads\tagclouds\ultimenu\src\UltimenuTool.php
-----------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------
119 | ERROR | [x] list(...) is forbidden, use [...] instead.
121 | ERROR | [x] list(...) is forbidden, use [...] instead.
185 | ERROR | [x] list(...) is forbidden, use [...] instead.
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------
FILE: C:\Users\SI-001\Downloads\tagclouds\ultimenu\ultimenu.info.yml
-----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
-----------------------------------------------------------------------------------------------------------
FILE: C:\Users\SI-001\Downloads\tagclouds\ultimenu\ultimenu.theme.inc
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
29 | ERROR | [x] Use null coalesce operator instead of ternary operator.
42 | ERROR | [x] Use null coalesce operator instead of ternary operator.
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------
Time: 1.34 secs; Memory: 14MB
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | interdiff_2-5.txt | 238 bytes | sourabhjain |
| #5 | 3302361-5.patch | 4.82 KB | sourabhjain |
| #2 | drupal-coding-standard-issue-3302361-2.patch | 5.17 KB | rakhi soni |
Comments
Comment #2
rakhi soni commentedkindly review patch,,
Comment #3
gausarts commentedThank you.
Please remove the line that says version:
The reason is written in the removed comment. More details about why are in Blazy, Slick issues. I don't want to repeat myself.
Comment #4
sourabhjainI will work on it.
Comment #5
sourabhjainI have resolved the issue mentioned in comment #3.
Please review.
Comment #6
gausarts commentedThanks.
Could anyone RTBC this?
I am hesitant to include it in the new release 2.8 as I have no time by now to figure out potential issues since you changed some logic in there.
I tend to think it is fine, but still hesitant specific to this change:
I received a few breaking patches last time. I normally fix them myself when I am available, but not for now.
That's why I am leaving it open for second eyes.
Feel free to convince us, be sure you identify and confirm the above issues addressed properly without any side kicks :)
Comment #8
gausarts commentedCommitted. Thank you for contribution and patience!
Comment #9
gausarts commented