$ phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml token_or/
Xdebug: [Step Debug] Time-out connecting to debugging client, waited: 200 ms. Tried: localhost:9000 (through xdebug.client_host/xdebug.client_port) :-(
FILE: C:\Users\SI-001\Downloads\token_or\modules\token_or_test\token_or_test.module
-----------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
-----------------------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
36 | ERROR | [x] Expected 1 blank line after function; 2 found
50 | ERROR | [x] Case breaking statements must be followed by a single blank line
53 | ERROR | [x] Case breaking statements must be followed by a single blank line
-----------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------
FILE: C:\Users\SI-001\Downloads\token_or\README.md
-----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-----------------------------------------------------------------------
3 | WARNING | [ ] Line exceeds 80 characters; contains 126 characters
7 | ERROR | [x] Expected 1 newline at end of file; 0 found
-----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------
FILE: C:\Users\SI-001\Downloads\token_or\src\TokenOrServiceProvider.php
------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------
19 | ERROR | [x] Expected 1 blank line after function; 0 found
20 | ERROR | [x] The closing brace for the class must have an empty line before it
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------
FILE: C:\Users\SI-001\Downloads\token_or\token_or.module
---------------------------------------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
3 | ERROR | [x] The second line in the file doc comment must be "@file"
6 | ERROR | [ ] Doc comment short description must end with a full stop
6 | ERROR | [ ] Doc comment short description must be on a single line, further text should be a separate paragraph
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------
Time: 269ms; Memory: 10MB
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | after-patch.png | 118.92 KB | sourabhjain |
| #4 | before-patch.png | 1.14 MB | sourabhjain |
| #2 | drupal-coding-standard-issue-3301802-2.patch | 2.29 KB | rakhi soni |
Issue fork token_or-3301802
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
rakhi soni commentedKindly review patch,,
Comment #3
sourabhjainI will review the patch.
Comment #4
sourabhjainI have reviewed the patch #2 and its looks good. Attaching before and after Screenshot for reference.
Moving to RTBC.
Comment #5
pianomansam commented@sourabhjain please create an issue fork and pull request for consideration.
Comment #6
pianomansam commentedComment #7
erikaagp commentedI'll work on it
Comment #8
erikaagp commentedHi! I fixed the issues, created an issue fork pushed the changes on the branch 3301802-drupal-coding-standard. The previews patch wasn't working so I replied the errors in order to correct them. Solved and ready for review!
Comment #9
erikaagp commentedComment #12
LeoAlcci commentedI will review!
Comment #13
pianomansam commentedComment #14
LeoAlcci commented