Plan for Context 7.x-3.12

Agreed. PHP 7.4 will not be supported in a couple months, so pushing a release for PHP 8 compatibility is important.

On Drupal 7.92 on 7.x-3.11 I was getting the following deprecation notice:

Deprecated: Required parameter $key follows optional parameter $type in /code/sites/all/modules/contrib/context/context.module on line 530

According to the PHP Watch documentation, removing the default value should remove the deprecation and shouldn't break any code, so I created a patch that removes the default value.

Moving this back to active... I was oversimplifying the interpretation of this article, and the patch introduced the following error (which makes sense when the optional parameter is essentially removed): ArgumentCountError: Too few arguments to function context_get_plugin(), 2 passed in /var/www/sites/all/modules/contrib/context/context.module on line 168 and exactly 3 expected in context_get_plugin() (line 530 of /var/www/sites/all/modules/contrib/context/context.module).

I wonder if the original deprecation notice might be a false flag, as it's flagging for $key and $type, not $reset (which is the "optional" parameter in line 530)?

Did you already apply this patch? https://www.drupal.org/files/issues/2021-04-09/context-n3208025-3.patch

That looks like the error you'd receive if you didn't apply it yet. Make sure you rebuild the site's cache.

See #3208025: PHP 8.0 compatibility for Context 7.x-3.x

+1 for the new release (with the PHP 8 compatibility fix included). Thanks!

Is there any concern needed to be addressed before releasing 7.x-3.12?

PHP 7.4 will reach it's EOL on 1st Jan, 2023 and PHP 8.2 is already out. PHP 8 support is kind of an important reason to release it ASAP. If there is no more standing issue with the current code, I would hope to urge the maintainer to publish this sooner rather than latert.

Agreed that getting a new release out would be good, then everybody upgrading to PHP 8 can avoid patching the context module. Raising the priority to major.

Came here to say that it would be great to see this release soon as I'm transitioning a handful of sites to PHP 8.1, and it would be nice to get a full release into our deploy process.

@DamienMcKenna Do you plan to release 7.x-3.12 anytime soon please? PHP 7.4 is EOL in 2023, so it would be great to have PHP 8 compatibility fixed. Thanks!

Oh, sorry. I totally missed this and assumed, that you are a maintainer, as you have created this plan :) I have pinged @paulocs about the release. And thanks for helping!

Sorry team, I haven't been very active in the last months in the context module and I don't have permission to give you access as co-maintainer. I'll try to reach out any maintainer with 'administer maintainers' permission so they can give me access.

Anyway here is the release: https://www.drupal.org/project/context/releases/7.x-3.12

Much appreciated @paulocs!