Problem/Motivation

The NodeType condition plugin was removed, but the logic for it in \Drupal\block\BlockForm::buildVisibilityInterface() was not.

Steps to reproduce

Proposed resolution

Remove the two if conditions for the node_type plugin ID.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3301663.patch1.69 KBcatch

Comments

Berdir created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3301663.patch1.69 KB
lucassc’s picture

lucassc
he/him
Primary language Portuguese, Brazil
Location Rio de Janeiro
commented
Assigned: Unassigned » lucassc
lucassc’s picture

lucassc
he/him
Primary language Portuguese, Brazil
Location Rio de Janeiro
commented
Assigned: lucassc » Unassigned

Hi!

I applied patch above for branch 10.0.x and it worked for me. I checked that 2 conditions refereed in proposed resolution for the node_type plugin ID were both removed.

If no other problems are found in the following reviews I think it can be mark as RTBC.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

Agreed it looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed 61e1feccf8 to 10.1.x and 62a402a389 to 10.0.x. Thanks!

  • alexpott committed 61e1fec on 10.1.x 
    Issue #3301663 by catch, Berdir, lucassc: Remove handling of node_type...

  • alexpott committed 62a402a on 10.0.x 
    Issue #3301663 by catch, Berdir, lucassc: Remove handling of node_type...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.