Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The CKEditor 35 update in #3301495: Update CKEditor 5 to 35.0.1 causes the test added for #3274937: Get CKEditor 5 to work in (modal) dialogs to start failing. In order to issue security hardening releases for the CKEditor 35.0.1 security advisory, we temporarily marked the test skipped in the 10.1.x and 10.0.x patches.
Proposed resolution
Un-skip the test and fix the regression.
Remaining tasks
TBD
User interface changes
Modal dialogs start working (again).
API changes
TBD
Data model changes
TBD
Release notes snippet
TBD
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | core-3301631-8-9.5x-combined.patch | 7.82 KB | nod_ |
| #8 | core-3301631-7.patch | 2.94 KB | nod_ |
| |||
| #4 | cke5-unskip-3301631-3.patch | 933 bytes | xjm |
| #2 | cke5-unskip-3301631-2.patch | 819 bytes | xjm |
Comments
Comment #2
xjmPatch to unskip the test (won't apply until #3301495: Update CKEditor 5 to 35.0.1 is committed).
Comment #3
nod_Comment #4
xjmUpdated patch that also removes the @todo comment.
Comment #5
xjmx-post
Comment #6
xjmNW to fix the bug, obvs. Test failure demonstrates what needs to be addressed.
Comment #8
nod_boum
giving credit to Taran2L for the discussion in slack about _allowInteraction.
Comment #9
nod_Patch for 9.5 that combines the patch from #3274937: Get CKEditor 5 to work in (modal) dialogs and the fix here.
Comment #10
Taran2Lhi @nod_, thanks for implementing this.
One question though, CKE4 is affected by the same issue. My idea was to fix it in the jQueryUI dialog like globally for CKE4/CKE5, but this is just an update for CKE5 leaving an extra JS file + library alter. Then, CKE4 will require (almost) the same thing, except the CSS class is different (however I see you have picked a very generic
ckone, which might work with CKE4 too).Is that how yo use this going forward: CKE4 and CKE5 implementing virtually the same thing separately, and other affected models do this as well?
Also, I'm curious whether multiple extensions do work fine simultaneously.Yes there are.One thing though, code extending dialog must run before any dialog is being initialized.
Comment #11
nod_This is about fixing the regression, so minimal code changes to address the problem and unblock things.
I'd like to talk about combining CKE5 and 4 fix in a separate issue so that we have the space to discuss the various implications.
Comment #12
lauriiiI think #9 should be posted on #3274937: Get CKEditor 5 to work in (modal) dialogs as the backport. On this issue, I think we should only commit #8.
Comment #13
Taran2LLooks good to me
Comment #16
lauriiiCommitted 4efef25 and pushed to 10.1.x and cherry-picked to 10.0.x. Thanks!