Problem/Motivation
Composer is fixed to docroot folder and should use web-root such as core composer to let use this project into custom folder.
Steps to reproduce
Having issues with custom composer build with Vardoc profile conflicting with changes over Vardoc Project template
When changed in projects, composer will face issues on builds and updates
Proposed resolution
1. Double-check what Drupal Recommended Project
https://github.com/drupal/recommended-project/blob/9.4.5/composer.json#L43
2. Check Acquia Drupal Recommended Project
https://github.com/acquia/drupal-recommended-project/blob/1.11.19/compos...
3. Use the right web-root in both Vardoc profile and Vardoc Project template
"drupal-scaffold": {
"allowed-packages": [
"drupal/core",
"vardot/varbase",
"vardot/vardoc"
],
"gitignore": true,
"locations": {
"web-root": "./docroot"
},
"file-mapping": {
"[web-root]/sites/default/default.services.yml": {
"mode": "replace",
"overwrite": false,
"path": "docroot/core/assets/scaffold/files/default.services.yml"
},
"[web-root]/sites/default/default.settings.php": {
"mode": "replace",
"overwrite": false,
"path": "docroot/core/assets/scaffold/files/default.settings.php"
},
"[web-root]/robots.txt": {
"append": "docroot/profiles/varbase/src/assets/varbase-robots-additions.txt"
}
}
},
Projects could change "web-root": "docroot/" and docroot to web using change or a clone of the Vardoc Project Template
Have drupal-scaffold locations web-root for Vardoc Project template as docroot to fix composer web-root folder in projects #41
Remaining tasks
- ✅ File an issue about this project
- ✅ Addition/Change/Update/Fix to this project
- ✅ Testing to ensure no regression
- ➖ Automated unit/functional testing coverage
- ➖ Developer Documentation support on feature change/addition
- ➖ User Guide Documentation support on feature change/addition
- ➖ Accessibility and Readability
- ✅ Code review from 1 Vardoc core team member
- ✅ Full testing and approval
- ✅ Credit contributors
- ✅ Review with the product owner
- ✅ Update Release Notes and Update Helper on new feature change/addition
- ✅ Release vardoc-4.0.6, Vardoc 5.0.0-alpha6
Vardoc update type
- ✅ No Update
- ➖ Optional Update
- ➖ Forced Update
- ➖ Forced Update if Unchanged
User interface changes
- N/A
API changes
- N/A
Data model changes
- N/A
Release notes snippet
Issue fork vardoc-3301450
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #4
rajab natshahShould be added too
Comment #5
rajab natshahComment #7
rajab natshahAfter double checking what Drupal Recommended Project is doing
https://github.com/drupal/recommended-project/blob/9.4.5/composer.json#L43
Reverting other changes
Only keeping the
Projects could change
"web-root": "docroot/"anddocrootto web using change or a clone of the Vardoc Project TemplateComment #9
rajab natshahComment #10
rajab natshahComment #11
rajab natshahComment #12
rajab natshahComment #13
rajab natshahHave drupal-scaffold locations web-root for Vardoc Project template as docroot to fix composer web-root folder in projects #41
Comment #14
rajab natshahComment #15
rajab natshahComment #16
rajab natshahComment #17
rajab natshahComment #18
rajab natshahComment #21
rajab natshahRestricting the use of changing files only to Drupal core and Varbase Profile
Not to let any package or module use the Drupal Scaffold to do any changes to Drupal files.
If a package was selected to do any change to files it should be listed in the Allowed Packages list.
Comment #22
rajab natshahComment #23
rajab natshahComment #24
rajab natshahComment #25
rajab natshahComment #26
rajab natshah✅ Released vardoc-4.0.6
Comment #27
rajab natshah✅ Released Vardoc 5.0.0-alpha6
Comment #28
rajab natshah