Problem/Motivation

When I override the Bootstrap variables and run "npm run build:sass" my terminal gives me an error that sass is missing.
I already checked the package.json file and saw that sass is missing.

Steps to reproduce

- Add something to a sass file inside the bootstrap5 theme.
- Run "npm install"
- Run "npm run build:sass"

Proposed resolution

Add sass to dev dependencies by running "npm install -D sass"

Issue fork bootstrap5-3301170

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

matdemeue created an issue. See original summary.

matdemeue’s picture

matdemeue
Primary language Dutch
Location Oudenaarde
commented

Ill give this one a try!

matdemeue opened merge request !11

matdemeue’s picture

matdemeue
Primary language Dutch
Location Oudenaarde
commented
Assigned: matdemeue » Unassigned
Status: Active » Needs review

I commited my fix and created a merge request.
It would be nice if someone could review it.

matdemeue’s picture

matdemeue
Primary language Dutch
Location Oudenaarde
commented
Issue summary: View changes

VladimirAus made their first commit to this issue’s fork.

vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented
Version: 1.1.3 » 1.1.x-dev
Status: Needs review » Reviewed & tested by the community

Thank you. Committed.

matdemeue’s picture

matdemeue
Primary language Dutch
Location Oudenaarde
commented

Hi Vladimir,

No problem!
Is it normal that I did not get a credit yet on my profile for this issue? :)
I'm kinda new on contributing to Drupal so I don't know in what stage of a solved issue, the credit appears.

Best regards,
Mathieu

omkar-pd’s picture

omkar-pd commented

Once the status of this issue is changed to fixed then you will get credit @matdemeue.

matdemeue’s picture

matdemeue
Primary language Dutch
Location Oudenaarde
commented

Ok thanks @omkar-pd!
I did not know that. :)

matdemeue’s picture

matdemeue
Primary language Dutch
Location Oudenaarde
commented
Status: Reviewed & tested by the community » Fixed
vladimiraus’s picture

vladimiraus
Primary language English
Location Brisbane 🇦🇺
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.