Problem/Motivation

When the user you want to delete is the author of more then 10 nodes, the user is blocked instead of deleted.

Steps to reproduce

Find a user that is the author of more then 10 nodes and then delete it's with this modules method.

Proposed resolution

Rewrite the bath_alter hook to expect more batches being set. (more then 10 nodes results in the user module to be updated in batch).

Remaining tasks

Review my patch, in first comment, and commit the solution if validated.

User interface changes

/

API changes

/

Data model changes

/

CommentFileSizeAuthor
#4 3301090-user-is-blocked-instead-of-deleted-4.patch1.46 KBtim@lammar.be
#3 3301090-user-is-blocked-instead-of-deleted-3.patch1.96 KBtim@lammar.be
#2 3301090-user-is-blocked-instead-of-deleted-#2.patch1.73 KBtim@lammar.be

Comments

Tim Lammar created an issue. See original summary.

tim@lammar.be’s picture

tim@lammar.be commented
StatusFileSize
new 3301090-user-is-blocked-instead-of-deleted-#2.patch1.73 KB

The patch that should do the trick.

tim@lammar.be’s picture

tim@lammar.be commented
StatusFileSize
new 3301090-user-is-blocked-instead-of-deleted-3.patch1.96 KB

Newer patch, as $batch['form_state'] is not always set.

tim@lammar.be’s picture

tim@lammar.be commented
StatusFileSize
new 3301090-user-is-blocked-instead-of-deleted-4.patch1.46 KB

Already a newer patch. This covers the case when multiple users get deleted as well. (We need to alter every batch for user_cancel, not only the first occurence)

berramou’s picture

berramou commented

Thank you @Tim Lammar for your report and your patch.
I will review and test the patch, it will be pushed next release.

  • berramou committed bf51843 on 1.0.x authored by Tim Lammar 
    Issue #3301090 by Tim Lammar: User is blocked instead of deleted if the...
berramou’s picture

berramou commented
Status: Active » Fixed
berramou’s picture

berramou commented
Status: Fixed » Closed (fixed)