This issue is created for D10 compatibility of the module to provide manual patches in separation to https://www.drupal.org/project/asset_injector/issues/3286112 that has got automated patches from the project bot that isn't fully resolving the compatibility issues.

CommentFileSizeAuthor
#2 asset-injector-d10-compatibility-3300734-2.patch4.25 KBfathima.asmat

Comments

fathima.asmat created an issue. See original summary.

fathima.asmat’s picture

fathima.asmat commented
StatusFileSize
new asset-injector-d10-compatibility-3300734-2.patch4.25 KB

A patch for fully fixing all the compatibility issues raised by upgrade status is attached here.

Before patch:

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      109  Call to deprecated function file_create_url(). Deprecated in
                    drupal:9.3.0 and is removed from drupal:10.0.0. Use the     
                    appropriate method on                                       
                    \Drupal\Core\File\FileUrlGeneratorInterface instead.        
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/asset_injector/tests/src/Functional/AssetInjectorCssTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      85   Call to deprecated function file_create_url(). Deprecated in
                    drupal:9.3.0 and is removed from drupal:10.0.0. Use the     
                    appropriate method on                                       
                    \Drupal\Core\File\FileUrlGeneratorInterface instead.        
--------------------------------------------------------------------------------

FILE:
web/modules/contrib/asset_injector/tests/src/Functional/AssetInjectorJsTest.php

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Fix later      93   Call to deprecated function file_create_url(). Deprecated in
                    drupal:9.3.0 and is removed from drupal:10.0.0. Use the     
                    appropriate method on                                       
                    \Drupal\Core\File\FileUrlGeneratorInterface instead.        
--------------------------------------------------------------------------------

FILE: web/modules/contrib/asset_injector/asset_injector.libraries.yml

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Check manually 0    The 'ace-editor' library is depending on a deprecated       
                    library. The "core/jquery.ui.resizable" asset library is    
                    deprecated in drupal:9.2.0 and is removed from              
                    drupal:10.0.0. See https://www.drupal.org/node/3067969      
--------------------------------------------------------------------------------
Check manually 0    The 'ace-editor' library is depending on a deprecated       
                    library. The core/jquery.once asset library is deprecated in
                    Drupal 9.3.0 and will be removed in Drupal 10.0.0. Use the  
                    core/once library instead. See                              
                    https://www.drupal.org/node/3158256                         
--------------------------------------------------------------------------------

After patch:

================================================================================
Asset Injector, --
Scanned on Fri, 07/29/2022 - 14:31

No known issues found.
fathima.asmat’s picture

fathima.asmat commented
Assigned: fathima.asmat » Unassigned
Status: Active » Needs review
pookmish’s picture

pookmish commented
Status: Needs review » Needs work

The patch applies cleanly. However there are a few issues with it at this time.

  1. jquery_ui_resizable module does not have a Drupal 10 version at this time.
  2. There should be an update hook if making another module a dependency

With these three issues, I'm tempted to remove the resizable dependency all together.

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented

Thanks everyone for participating in porting day and moving these issues forward :)

pookmish’s picture

pookmish commented
Status: Needs work » Fixed

I took most of the provided patch, but removed the "resizeable" dependency and javascript use.

I also updated Ace Editor in the process. Closing this as fixed. Please add any other D10 updates on #3286112: Automated Drupal 10 compatibility fixes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.