FILE: C:\xampp\htdocs\drupal95\web\modules\contrib\commerce_gallery\src\Plugin\Block\CommerceGalleryBlock.php
-------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------
41 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
68 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
-------------------------------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | Drupal-calls-avoided-new-3300646-6.patch | 2.62 KB | Harsh panchal |
| #2 | Drupal-calls-should-avoid-3300646-2.patch | 2.57 KB | Harsh panchal |
Issue fork commerce_gallery-3300646
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3300646-drupal-calls-should
changes, plain diff MR !5 /
changes, plain diff MR !7 /
changes, plain diff MR !6
Comments
Comment #2
Harsh panchal commentedI have fixed this and providing a patch.
Comment #3
kecsotComment #4
kecsotI've tested the patch.
Missing __construct parameters and parent call also missing.
Forgot to format code.
Needs work.
Comment #5
Harsh panchal commentedHi @kecsot
I got this issue i will provide a new patch.Thanks
Comment #6
Harsh panchal commentedI have fixed #4 issues and providing a new patch.
Comment #7
sujan shrestha commentedComment #16
sujan shrestha commented