Problem/Motivation

JSON:API support preview draft revision. It is possible to preview the entity with Version negotiator. But currently Drupal\jsonapi\Revisions\VersionByRel Negotiator does not support language fallback candidates.

CommentFileSizeAuthor
#2 jsonapi-negotiator-by-rel-language-fallback-support-3299843.patch4.22 KBihor_allin

Comments

ihor_allin created an issue. See original summary.

ihor_allin’s picture

ihor_allin commented
StatusFileSize
new jsonapi-negotiator-by-rel-language-fallback-support-3299843.patch4.22 KB

Status: Needs review » Needs work

The last submitted patch, 2: jsonapi-negotiator-by-rel-language-fallback-support-3299843.patch, failed testing. View results

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

giuseppe87’s picture

giuseppe87 commented

Thanks for the patch, I have a similar case and it works.

However, is actually getFallbackLatestTranslationAffectedRevisionId necessary? Despite getLatestTranslationAffectedRevisionId can theorically return null, I couldn't find a case when it actually does that.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.