The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Problem/Motivation
Upgrade to https://github.com/mglaman/phpstan-drupal/releases/tag/1.1.21 to allow testing PHP 8.2.
The fix https://github.com/mglaman/phpstan-drupal/commit/8acaa1e4a15b266cfbd404c... is required to allow phpStan to run on core
OTOH CI run still fails
Steps to reproduce
See https://www.drupal.org/pift-ci-job/2420734
Proposed resolution
- decide why CI still broken, probably because of composer version
- asked for upgrade https://drupal.slack.com/archives/C033S2JUMLJ/p1657740913314079
- upgrade to latest release
Remaining tasks
- find a cause
- patch/commit
User interface changes
no
API changes
no
Data model changes
no
Release notes snippet
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | interdiff_4-14.txt | 3.65 KB | spokje |
| #14 | 3299606-14.patch | 7.55 KB | spokje |
Comments
Comment #2
spokjeComment #3
spokjeCan it be this easy?
Comment #4
spokjeDuplicate of #3295821-62: Ignore: patch testing issue for PHP 8.2 attributes
Comment #5
spokjeComment #6
spokjeComment #7
andypostI think we should raise requirement if we will declare compatibility
And this is not duplicate, patch testing issue is not supposed to be commited
Comment #8
andypostUpdated IS to point why this still makes sense
Comment #9
andypostI recall @xjm already pointed that this upgrade can cause a lot of new warnings, assigning to her to call details
Comment #10
longwaveBaseline needs regenerating because this upgrade solves the false positives in #3259716: Replace usages of static::class . '::methodName' to first-class callable syntax static::method(...)
Comment #11
mondrake#3295618: Get PHPStan baseline generation via DrupalCI would help in regeneration of baseline as part of patches preparation.
Comment #12
andypostThank you but I'm afk til evening
Comment #13
spokjeComment #14
spokjeI'm always insecure about when to do this, to me it seems quite random ATM: For example: we didn't do it for the update for phpstan itself and don't seem to be doing it for the composer/composer update in another child issue.
Anyway: rebuild the phpstan baseline (
vendor/bin/phpstan analyze --configuration=core/phpstan.neon.dist --generate-baseline ./core/phpstan-baseline.neon)Comment #15
andypostQueued for 8.2 too
Comment #16
spokjeComment #17
spokjeComment #18
mondrakeRe #14: IMHO we should bump the version requirements when the upgrade to a new version require changes to the baseline. Like here. Otherwise running the analysis on older version may throw errors.
Comment #19
spokjeThanks @mondrake for explaining, makes sense
Comment #20
mondrakeLooks good to me, thanks
Comment #21
andypostSo the only blocker to prevent timeout is #3299213: Require mikey179/vfsstream ^1.6.11 to allow tests running on PHP 8.2
Comment #24
catchCommitted/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!
Comment #25
xjmDoes this also need to be backported to 9.5.x which should also presumably be made compatible with PHP 8.2? Edit: Looks like we don't have this dependency there, which is slightly confusing.