Replace static code with dependency injection

Assigning it to my name.

Will try to work on this one =)

After running phpcs I found another possible D.I. issue:

FILE: /modules/contrib/content_planner/src/ContentModerationService.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------
74 | WARNING | ContentModerationState::loadMultiple calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------

Changing status to needs work.

Alright @DieterHolvoet, rookie here, I'm sorry, and thanks for the clarification.

Patch for #5.

Kindly review.

@DieterHolvoet, nice, I will keep working on this then =).

If possible I would like more details on this one, I am getting a bit blocked.

I wrote this new patch with both the previous patch changes and a few more.

Any help for improving is welcome.

Kindly review.

Hi, it's my first reroll I hope it's ok. Here's the patch:
If someone could review it. Thanks :)

I could make the reroll of patch 12 without the previous patch being added :) If someone could please review it.

Reviewed patch from #16, it applies.
Removed reroll tag.
Changing to needs work.
Will try to work on #13 comment changes.

I am not 100% sure this is correct, any tips are welcome for improving this.
Unassigning myself.
Will keep as needs work as it is not finished.

I´ll try to look on that

I found some bugs and made some changes, please review

I'll be reviewing this one.

I found and fixed some bugs.

I applied the patch in #23 and verified that:

1) Searches didn't revel any occurrence of EntityInterface::load() or EntityInterface::loadMultiple();

2) No phpcs warnings like "\Drupal calls should be avoided in classes, use dependency injection instead" was found;

3) @diegors' patch in #21:

@@ -111,7 +109,8 @@ class UserBlock extends DashboardBlockBase {
    */
   protected function getUserContentCount($user_id) {
 
-    $query = \Drupal::database()->select('node_field_data', 'nfd');
+    $database = \Drupal::database();
+    $query = $database()->select('node_field_data', 'nfd');
     $query->fields('nfd', ['nid']);
     $query->condition('nfd.uid', $user_id);
     $query->countQuery();

Here could the create method still be overridden as described in #13? See Dependency injection in Plugin (Block) and check the create method of the UserBlock's parent class (DashboardBlockBase).

Edit: I realized that in #19 @Joel Guerreiro Borghi Filho attached an interdiff that implements changes suggested in #13 but I couldn't find his patch.

i'll work on those errors

I did some changes that was reported in phpcs and removed the call of \Drupal::database.
The statics methods that i found was changed to non-statics calls.

I'll review this.

Fixed the remaining errors.

Please review.

I'll be reviewing

The phpcs doesn't show any error and while testing the module everything goes fine. Passing to RTBC.