http://api.drupal.org/api/function/node_configure_validate/7

for D6 and D7 we should be using a button submit handler. For D5, I guess this was done out of laziness of not wanting to set up the #submit array properly?

CommentFileSizeAuthor
#1 wrong-goto-329660-7x-1.patch1.47 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new wrong-goto-329660-7x-1.patch1.47 KB
robloach’s picture

robloach
he/him
commented
Status: Needs review » Reviewed & tested by the community
  1. Fresh install
  2. Applied patch
  3. Cleared cache
  4. Added a row in the node_access table
  5. Cleared cache
  6. Visited admin/content/node-settings
  7. Saw Rebuild permissions
  8. Clicked rebuild permissions
  9. Saw a confirm clear permissions page
  10. Confirmed to clear permissions
  11. Don't see Rebuild permissions anymore
  12. Danced around un-wronged code and set to RTBC
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Version: 7.x-dev » 6.x-dev

Ahhh. Much better.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented

Er:

"Committed to HEAD. Thanks! Marking back to 6.x for consideration." :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Committed to Drupal 6.x.

pwolanin’s picture

pwolanin commented
Version: 6.x-dev » 5.x-dev
Status: Fixed » Patch (to be ported)

we could backport this to 5.x if drumm is interested

marcingy’s picture

marcingy commented
Status: Patch (to be ported) » Closed (won't fix)

Marking as won't fix as d5 is end of life.