Problem/Motivation

When adding an override via the theme settings form, the redirect leads to a blank page instead of getting redirected back to the theme settings form. This happens because the current code in ComponentOverrideForm::ajaxSubmit() checks whether there is a redirect destination, which is set, but is not correct when submitting the form coming from the theme settings.

Steps to reproduce

Go to the theme settings form and add an override via the local action link.

Proposed resolution

Check whether the destination query parameter is actually set or not and redirect back to the theme settings in case it is not.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

s_leu created an issue. See original summary.

s_leu’s picture

Status: Active » Needs review

Tim Bozeman made their first commit to this issue’s fork.

  • Tim Bozeman committed 9017f19 on 1.0.x authored by s_leu
    Issue #3296114: Redirect from component override broken when adding via...
tim bozeman’s picture

Status: Needs review » Fixed

Rebased and merged. Thank you! 🚀

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.