Problem/Motivation

Add the function to delete OpenStack Snapshot in the SPA.

Issue fork cloud-3295873

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Masami created an issue. See original summary.

masami’s picture

Status: Active » Needs review
ryo yamashita’s picture

@masami @yas

Regarding getEntity() in OpenStackOperationsService and AwsCloudOperationsService,
it is implemented to use EntityDeleteFormTrait trait.
Which of the following should be written?

// Plan A: Does not describe the return type
  public function getEntity() {
    return $this->entity;
  }

// Plan B: Describe only EntityInterface type
  public function getEntity(): EntityInterface {
    return $this->entity;
  }

// Plan C: Adapt to form notation
  public function getEntity(): ContentEntityInterface|RevisionLogInterface {
    return $this->entity;
  }
yas’s picture

@ryo-yamashita

According to the comment at https://git.drupalcode.org/project/drupal/-/blob/9.5.x/core/lib/Drupal/C..., it looks Plan B.

Thanks

yas’s picture

Status: Needs review » Needs work

@masami

Can you please take a look at the comments? Thanks

masami’s picture

Status: Needs work » Needs review
ryo yamashita’s picture

@masami @yas

I have read the patch and it looks good. Thanks.

yas’s picture

Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for your review.

@masami

Thank you for the update. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 5923871 on 5.x authored by Masami
    Issue #3295873 by Masami, yas, Ryo Yamashita: Add the function to delete...

  • yas committed ed93fa4 on 4.x authored by Masami
    Issue #3295873 by Masami, yas, Ryo Yamashita: Add the function to delete...
yas’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.