Problem/Motivation

With PHP 8.1 the reference form throws deprecation warnings when validating the contributor field.

Steps to reproduce

Proposed resolution

Make sure to not pass NULL to contributor name part query conditions in class ContributorSelection. This will stop the warning and improve performance by not needlesly adding a no-op LIKE condition to the query.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 bibcite_entity-php81-addcslashes-passing-null-3295484-8.patch1.03 KBeric_a
#5 bibcite_entity-php81-addcslashes-passing-null-3295484-5.patch1.02 KBeric_a

Comments

Eric_A created an issue. See original summary.

eric_a’s picture

eric_a commented
Issue summary: View changes
eric_a’s picture

eric_a commented
Issue summary: View changes
eric_a’s picture

eric_a commented
Issue tags: +Performance
eric_a’s picture

eric_a commented
Status: Active » Needs review
StatusFileSize
new bibcite_entity-php81-addcslashes-passing-null-3295484-5.patch1.02 KB
eric_a’s picture

eric_a commented

The fail on PHP 8.1 is pre-existing and actually fixed by #3294897: Deprecated function: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\Component\Utility\Html::escape() .

eric_a’s picture

eric_a commented
Assigned: eric_a » Unassigned
eric_a’s picture

eric_a commented
StatusFileSize
new bibcite_entity-php81-addcslashes-passing-null-3295484-8.patch1.03 KB

Fixed coding standards issue "Inline control structures are not allowed".

web-beest’s picture

web-beest
he/him
Primary language Dutch
commented
Status: Needs review » Reviewed & tested by the community

Works for me, thanks!

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented

Same

alison’s picture

alison
she/her
commented

Same same!

Thanks so much for the fix, those log floods were super annoying (and, as log floods do, sent us down the wrong rabbit hole while debugging a Real Problem).

  • Eric_A authored b154ffbf on 2.0.x 
    Issue #3295484 by Eric_A: Deprecated function: addcslashes(): Passing...

  • AardWolf committed 811cf05a on 3.0.x authored by Eric_A 
    Issue #3295484 by Eric_A: Deprecated function: addcslashes(): Passing...

hxdef credited AardWolf.

hxdef’s picture

hxdef commented
Status: Reviewed & tested by the community » Fixed

Thanks a lot for the fix! Added it to the module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.