FILE: D:\xampp\htdocs\drupal9.5\web\modules\contrib\grid_widget\css\form--checkboxes.css
----------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal9.5\web\modules\contrib\grid_widget\css\form--radios.css
------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal9.5\web\modules\contrib\grid_widget\grid_widget.module
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
19 | ERROR | [ ] The array declaration extends to column 770 (the limit is 80). The array content should be split up over multiple lines
------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------

FILE: D:\xampp\htdocs\drupal9.5\web\modules\contrib\grid_widget\src\Plugin\Field\FieldWidget\OptionsGridWidget.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
32 | WARNING | [x] A comma should follow the last multiline array item. Found: 3
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#2 phpcs-drupal-coding-standard-3295427-2.patch2.43 KBHarsh panchal
#4 Screenshot from 2022-07-12 11-26-21.png69.91 KBakshaydalvi212
#6 phpcs-drupal-coding-standard-3295427-6.patch3.16 KBakshaydalvi212

Comments

Harsh panchal created an issue. See original summary.

Harsh panchal’s picture

Harsh panchal commented
Category: Task » Bug report
Status: Active » Needs review
StatusFileSize
new phpcs-drupal-coding-standard-3295427-2.patch2.43 KB

I have fixed phpcs standard issue and providing a patch.

akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: Harsh panchal » akshaydalvi212

Hello Harsh panchal,

I will review this patch.

Thanks & Regards

akshaydalvi212’s picture

akshaydalvi212 commented
Issue summary: View changes
StatusFileSize
new Screenshot from 2022-07-12 11-26-21.png69.91 KB

Hello Harsh panchal,

After applying the patch, still getting some warnings as follows:

I will resolve the remaining warnings and will provide updated patch for the same.

Thanks and regards.

akshaydalvi212’s picture

akshaydalvi212 commented
Status: Needs review » Needs work
akshaydalvi212’s picture

akshaydalvi212 commented
Assigned: akshaydalvi212 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new phpcs-drupal-coding-standard-3295427-6.patch3.16 KB

Hello all,

providing the updated patch, which resolved the above mention warnings.
kindly review the same and provide your feedback on same.

Thanks & regards.

Harsh panchal’s picture

Harsh panchal commented

Hi @akshaydalvi212
I have also created a new issue and his patch for #4 comment warnings please check.#4 was a Drupal--standardpractice warnings issue.Thanks

akshaydalvi212’s picture

akshaydalvi212 commented

Hi @Harsh panchal,

ideally, we can make a single patch and solve all the errors and warnings related to Drupal standard and DrupalPractice standard.
but, you have already created another issue, we can go further with your approach.
I will review that issue and will switch this issue to Reviewed and tested by community status.

Thanks and regards.

akshaydalvi212’s picture

akshaydalvi212 commented
akshaydalvi212’s picture

akshaydalvi212 commented
Status: Needs review » Reviewed & tested by the community

  • Harsh panchal authored 2505171 on 1.0.x 
    Issue #3295427 by akshaydalvi212, Harsh panchal: Phpcs Drupal coding...
littlecoding’s picture

littlecoding
He/Him
Location Hamilton, ON
commented
Status: Reviewed & tested by the community » Fixed

Translation warning/error are going to be handled in their own issue https://www.drupal.org/project/grid_widget/issues/3295428

Nisha.Jain’s picture

Nisha.Jain commented

Thanks Harsh,Your patch worked for me..

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.