Problem/Motivation

Spin-off from #3269141: Remove deprecated Drupal\Core\StringTranslation\TranslationWrapper to TranslatableMarkup in Drupal 11.

There is no obvious best solution on that issue, so I think for now we should leave the wrapper in for another release and try to remove it again during the 10.x-11.x cycle.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#5 3295421-5.patch2.51 KBgábor hojtsy
#5 interdiff.txt1.12 KBgábor hojtsy
#2 3295421.patch1.39 KBcatch

Issue fork drupal-3295421

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
Related issues: +#3269141: Remove deprecated Drupal\Core\StringTranslation\TranslationWrapper to TranslatableMarkup in Drupal 11
StatusFileSize
new 3295421.patch1.39 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3295421.patch, failed testing. View results

atuliet05 made their first commit to this issue’s fork.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.12 KB
new 3295421-5.patch2.51 KB

Updating the test too.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Parent issue: » #3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch

And parenting to #3213895: [META] Remove deprecated classes, methods, procedural functions and code paths outside of deprecated modules on the Drupal 10 branch since this is resolving a deprecation.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Issue tags: +Deprecation Removal
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

I find it ready to go in

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Version: 9.5.x-dev » 9.4.x-dev
Status: Reviewed & tested by the community » Fixed

Backported to 9.4.x as correct deprecation messages are useful.

Committed and pushed 1b1c8ecacd to 10.1.x and 46d6e68b3c to 10.0.x and 469e117c9e to 9.5.x and cb65264dbe to 9.4.x. Thanks!

  • alexpott committed 1b1c8ec on 10.1.x 
    Issue #3295421 by Gábor Hojtsy, catch, atuliet05: Update...

  • alexpott committed 46d6e68 on 10.0.x 
    Issue #3295421 by Gábor Hojtsy, catch, atuliet05: Update...

  • alexpott committed 469e117 on 9.5.x 
    Issue #3295421 by Gábor Hojtsy, catch, atuliet05: Update...

  • alexpott committed cb65264 on 9.4.x 
    Issue #3295421 by Gábor Hojtsy, catch, atuliet05: Update...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.