Drupal 10 readiness meeting / 4 July 2022 [#3295268]

Meeting will happen in #d10readiness on drupal.slack.com.

Hello and welcome to this Drupal 10 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 10 upgrade of their sites are also welcome.
➤ Now happens every Monday at 18:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: `https://www.drupal.org/project/drupal/issues/3295268`
➤ *Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️⃣ Who is here today? Comment in the thread below to introduce yourself.

Kristen Pol (she/her)	Kristen, Central California :wave: (I expect it to be fairly quiet for US folks as it's a US holiday) (edited)
Ilcho Vuchkov (vuil)	Ilcho Vuchkov, Bulgaria EU, Modules Co/Maintainer
andypost	Andy, contributor
dww	Derek @ TEN7
Spokje	Spokje, drive-by comment-dropping today.
shaal	Ofer Shaal
Björn Brala (bbrala)	Björn, distracted for a bit.
Asish Sajeev	Asish Sajeev, Developer, India (edited)
kimb0	Kim, Au
quietone	Hi

1️⃣ Do you have suggested topics you are looking to discuss? Post in this thread and we'll open threads for them as appropriate.

Kristen Pol (she/her)	#3291535: META: Organize 2022 Drupal 10 porting day or weekend contribution events
Kristen Pol (she/her)	Rector rule update
Kristen Pol (she/her)	Deprecations for test in CI (summary from last meeting)
dww	Updates on QuickEdit deprecation / removal hell
andypost	PHP 8.2 alpha3 coming this week, D-CI need needs docker image and main issue #3282315: Update phpstan/phpstan and mglaman/phpstan-drupal to latest versions

2️⃣ Looking for feedback on possible Drupal 10 porting events this year

Kristen Pol (she/her)

#3291535: META: Organize 2022 Drupal 10 porting day or weekend contribution events

3️⃣ Update on recent rector update fixes

Kristen Pol (she/her)	There was a thread about this last time and it would be good to know where we are at and if there are any major issues that still need attention
andypost	is tehre issue for it?
Kristen Pol (she/her)	let me check
Kristen Pol (she/her)	old thread: https://drupal.slack.com/archives/C014CT1CN1M/p1656353325841899
Kristen Pol (she/her)	issues #3292939: Fatal error: Uncaught AssertionError: assert($pathValue instanceof Node\Scalar\String_)
Björn Brala (bbrala)	I have not seen activity on the issues. And I know @mglaman has been quite busy.
mglaman	This is true. I've been pretty busy and feeling burnt out. However, work will be focusing on D10. Pushing to focus my time on tooling vs modules. All of that is in progress at the moment
Björn Brala (bbrala)	Keep a realistic balance :slightly_smiling_face: :heart:
Gábor Hojtsy (he/him)	@mglaman hope you can get sponsored time to work on it :crossed_fingers: I think your time spent on scaling community work is better than you working on one by one modules :slightly_smiling_face:

4️⃣ TL;DR from "DrupalCI not failing on PHPUnit deprecations" discussion

Kristen Pol (she/her)

Discussed at length last meeting but this TL;DR may be helpful for those who missed ithttps://drupal.slack.com/archives/C014CT1CN1M/p1656441268995909?thread_t...

5️⃣ Update on deprecation and removal of QuickEdit (edited)

Kristen Pol (she/her)	raised by @dww with some cussing :wink:
dww	I think we've got a working contrib QE for 9.4.x and 9.5.x at #3291700: new subtree split of core Quick Edit into contrib (v2)
dww	Any final help testing that would be nice.
dww	But it doesn't pass tests on 10.0.x. So we'll need Yet Another(tm) subtree split for that (we hope that's sufficient).
dww	#3292780: Move Quick Edit related Javascript from core/modules/ckeditor5/js/ckeditor5.es6.js::detach() to the Quick Edit module seems to be the last [sic] :pray: :crossed_fingers: core issue
andypost	@dww is facade already working? as I see it still `drupal/quickedit-quickedit`
dww	That one definitely needs help. :point_up: Other than that, it's just [sic] all the other stuff that's already open, from #3274155: [Meta] Tasks to remove Quick Edit from core and move to contrib (still not totally sure why we need both metas, frankly).
dww	No, façade is still busted on:Deadlocked dependencies for #3292303: Remove replace section in core/composer.json for several deprecated modules
Spokje	Lay of then land AFAICT:Façade itself is working for 'hal','color','aggregator','tracker','quickedit'(See https://git.drupalcode.org/project/project_composer/-/blob/7.x-1.x/proje...)Somehow project pages still show drupal/module-moduledrupal/quickedit-quickedit is a "special" case that was somehow/somewhere manually added and could/should/can be deleted at any point in time.Unsure why the Contrib QE subtree split hates 10.0.x, motivation not found (yet) to look into that.#3292780: Move Quick Edit related Javascript from core/modules/ckeditor5/js/ckeditor5.es6.js::detach() to the Quick Edit module is currently the last know code-blocker for QE, but requires much more JS-knowledge than I possess. If no-one snatches it, xjm promised some JS-BigBrains from the FrontEnd pool to look at it somewhere this week.All of the above is of no use to us/normal users until #3266476: Ensure that quickedit does not get special core treatment lands, absolutely unsure why that's stuck.Not specifically QE related, but I feel we really can't get away with point #5 in #3292932: [Policy, no patch] Deprecating/Removing Core Modules When updating from 9.4.x/9.5.x to 10.0.x and having deprecated (and now removed modules) we do give a warning (See https://www.drupal.org/files/issues/2022-07-04/image.png ), however the linked page (https://www.drupal.org/docs/updating-drupal/troubleshooting-database-upd...) does not tell about composer require-ing the Contrib Incarnation. Also this warning is the "standard" one for missing modules. Do we need to make this more specific for removed Core modules?So that would complicate/delay/Sisyphusify things even more.

6️⃣ PHP 8.2 alpha3 coming this week, CI needs docker image and main issue (edited)

Kristen Pol (she/her)	raised by @andypost
Kristen Pol (she/her)	#3282315: Update phpstan/phpstan and mglaman/phpstan-drupal to latest versions (edited)
andypost	Also #3259716: Replace usages of static::class . '::methodName' to first-class callable syntax static::method(...) needs more eyes as it will affect contrib a lot
dww	I'm following 3259716 -- hope to make time for it once QE settles down a bit. :wink:
andypost	@hestenet (he/him) @mixologic any help needed for #3283449: Create a DrupalCI Environment for PHP 8.2 this Thursday release will be anounced and tarball will appear tomorrow
andypost	Would be great to get more eyes on way to fix #3275858: View's ResultRow uses deprecated dynamic properties - probably the easiest way to add attribute
dww	Now following, thanks
hestenet (he/him)	@andypost Thanks for the updates and the heads up on the Thursday release - we're just finding ourselves busy with many different requerst but will try to get there soon.
berdir	In case it helps others, I just created a pull request to add a php82 container to ddev-contrib: https://github.com/drud/ddev-contrib/pull/214. Have a working D10 project now on PHP 8.2. There are a million deprecation messages of course, but I can see the installer :wink:
andypost	@hestenet (he/him) @mixologic alpha3 packaged https://downloads.php.net/~sergey/
hestenet (he/him)	:thankful:
hestenet (he/him)	Happening faster than we've been able to get there, but thakns!
andypost	NP announce should be available in 2 days
hestenet (he/him)	PHP 8.2 alpha container should be deployed this morning.
andypost	is there support for AVIF added?
hestenet (he/him)	^^ I believe the 8.2 one should have it as well - cc @mixologic
andypost	would be great to add it to 8.1 too so we can test 10.1.x patches for it
andypost	ah that's phpstan-drupal /cc @mglaman https://www.drupal.org/pift-ci-job/2420734 (edited)
mglaman	about static::class, @longwave may have fixed my shortcomings on that assumption: https://github.com/mglaman/phpstan-drupal/pull/436
mglaman	for test failure: https://github.com/mglaman/phpstan-drupal/issues/441
mglaman	Unfortunately I haven’t had bandwidth to work on any tooling. Trying to see how this can be part of my day-to-day as I’m onramping to D10 readiness work
berdir	@hestenet (he/him) https://dispatcher.drupalci.org/job/drupal_patches/136717/console is at a 500MB logfile. you might want to pause 8.2 tests until the most glaring issues with serviceid and the Extension classes are resolved, no point in running tests there atm I think, might just mess up DrupalCI?
berdir	cc @andypost ^
hestenet (he/him)	Hm.. cc @mixologic and @andypost --- don't want to cross the streams
hestenet (he/him)	Heh, yes
hestenet (he/him)	We can 'pause' just by turning it off in the project config - which the maintainers can do or people can do by not selecting it in issue testing - doesn't necessarily need our direct intervention, but yeah
berdir	do we have an issue for Extension::$origin and $subpath? can't find one atm
andypost	@berdir thanks! there's 2 issues[#2024043]
andypost	still not sure which one better, for now the attribute #[\AllowDynamicProperties] is the best workaround #3275858: View's ResultRow uses deprecated dynamic properties#comment-14597065
andypost	@berdir maybe there's a way to add this kind of deprecations to excludes somehow, I'm not much familar with latest changes to deprecation listener and exclude files
andypost	and the porimary one is #2531564: Fix leaky and brittle container serialization solution
andypost	@mglaman simple fix https://github.com/mglaman/phpstan-drupal/pull/442
mglaman	thank you for fixing this fork of core code!
mglaman	i’ll merge and release via the github ui
mglaman	I wish there was a way to not need this forked
andypost	oh, the same issue in core( (edited)
mglaman	blarghError: composer/installers contains a Composer plugin which is blocked by your allow-plugins config. You may add it to the list if you consider it safe. You can run "composer config --no-plugins allow-plugins.composer/installers [true\|false]" to enable it (true) or disable it explicitly and suppress this exception (false) See https://getcomposer.org/allow-pluginswhatever, merging and tagging patch release
mglaman	https://github.com/mglaman/phpstan-drupal/releases/tag/1.1.21
mglaman	thanks @andypost
berdir	@andypost https://dispatcher.drupalci.org/job/drupal_patches/136726/console, now it's full of that still and everything fails still. we could try with the patch from #2531564: Fix leaky and brittle container serialization solution included as well, but we should just focus on getting those two main issues resolved first
berdir	and #3292759: Create getters and setters for dynamic Extension properties interestingly deals with different properties but not the main two that we're seeing there
andypost	@mglaman filed follow-up for core #3294827: Fix preg_match() usage when looking for extension type
andypost	still not clear why NULL hapens here
andypost	@berdir also lots of tests affected by this serviceId as mocks accessing it often
andypost	FYI xdebug for alpha 3 is tested by typo3, ref https://git.typo3.org/typo3/CI/testing-infrastructure/-/commit/514aaebac...