Closed (fixed)
Project:
Mailgun
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
8 Jul 2022 at 08:07 UTC
Updated:
9 Aug 2022 at 19:24 UTC
Jump to comment: Most recent
Tried to install this module but has dependency issues, mailgun should be upgraded to latest version.
Issue fork mailgun-3294896
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
gayatri chahar commentedComment #4
parisekTested and it seems working great, just this drop support for PHP 5
https://github.com/mailgun/mailgun-php/releases/tag/3.0.0
https://github.com/php-http/guzzle6-adapter/releases/tag/v2.0.0
Comment #5
gayatri chahar commentedComment #6
matroskeenWhen I update mailgun/mailgun-php and guzzle6-adapter to the corresponding versions, I have the following error in my local environment:
Http\Discovery\Exception\NotFoundException: No PSR-17 url factory found. Install a package from this list: https://packagist.org/providers/psr/http-factory-implementation@parisek can you check if you have any of those extensions? It'll explain why you didn't hit this in your tests.
I wonder if we should include one of the implementations in
composer.jsonfile (as we do for Drupal 8+), or if it's up to developer to decide which one to pick. See: https://github.com/mailgun/mailgun-php#installationComment #7
parisek@Matroskeen Great assumtion, I have custom module with https://github.com/mailerlite/mailerlite-api-v2-php-sdk which has https://github.com/nyholm/psr7 dependency, I think it's save to require this dependency in drupal module composer?
Comment #8
matroskeenYep, it should be safe. We do this for Drupal 8+: https://git.drupalcode.org/project/mailgun/-/blob/8.x-1.x/composer.json
Moving back to needs work to include this dependency.
Comment #9
parisekOk backported from D8 version
Comment #11
matroskeenLooks good to me! Thank you!