Problem/Motivation

Running the search for a phrase in a Paragraph library returns an error

Note that this does NOT happen when you go straight to a replace without first searching.

Steps to reproduce

Enable the Paragraphs sub-module Paragraphs Library.
Create a Paragraph Library Item.
Search for a text you entered in the Paragraph Library Item.

Proposed resolution

Support the paragraphs_library_item entity type.

Remaining tasks

Patch

CommentFileSizeAuthor
#3 scanner-skip-library-items-3294162-3.patch616 bytesjlicht
#2 3294162-errors-on-search-only.patch22.99 KBjffranck

Issue fork scanner-3294162

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Papa Ours created an issue. See original summary.

jffranck’s picture

jffranck commented
StatusFileSize
new 3294162-errors-on-search-only.patch22.99 KB

Here is a patch I made for this issue.

I also:

  • improved the way "view" and "edit" links were managed, so they can work with other entity types than node.
  • added support for search/replace in Paragraph libraries
jlicht’s picture

jlicht commented
StatusFileSize
new scanner-skip-library-items-3294162-3.patch616 bytes

Here's a different patch, which just removes the error (by skipping scanning of library items) rather than making more far-reaching changes.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review

Thank you for your work on this bug. Let's see what the testbot says.

smustgrave’s picture

smustgrave commented
Version: 8.x-1.0-rc6 » 2.0.x-dev
Status: Needs review » Needs work

Can the fix be put into an MR

smustgrave opened merge request !41

  • smustgrave committed b466ae63 on 2.0.x 
    Issue #3294162 by papa ours, jlicht: Errors on search-only for...
smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

saw this one something else random and #3 solved it for me.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3577750: Plan for Scanner 2.0.0