Looks like \Drupal\Tests\filter\Kernel\TextFormatElementFormTest::getUrl() is unneeded.
The simpletest bit in the comment kinda gives it away already:
// \Drupal\simpletest\AssertContentTrait needs this for ::assertFieldByName
// to work.
As the ever watchful longwave pointed out: It's parent \Drupal\KernelTests\AssertContentTrait::getUrl() is also in the land of the dodos and can be removed.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | 3293952-d10-10.patch | 1.24 KB | spokje |
| #9 | interdiff_2-9.txt | 464 bytes | spokje |
| #9 | 3293952-9.patch | 1.25 KB | spokje |
Comments
Comment #2
spokjeComment #3
spokjeComment #4
longwaveI think the parent implementation is unused as well - I discovered the same in #3293216: Rename references to Simpletest in tests but I think it's clearer to handle all this in this separate issue.
Comment #5
spokjeComment #6
longwaveSorry - I meant clearer to handle this in this issue :)
Let's delete
AssertContentTrait::getUrl()here as well, as it's not used.Comment #7
spokjeAh, misunderstood that completely :)
Comment #8
spokjeComment #9
spokjeComment #10
spokjeComment #11
spokjeComment #12
longwaveThank you @Spokje.
Comment #13
alexpottCommitted and pushed d17bde5df6 to 10.1.x and f8cbc71d31 to 10.0.x. Thanks!
I think this is okay to do in 10.0.x this methods are long unused in core. I think given the extremely niche use-case - to make a content assertion work in KTB - it is fine to remove this from D10 alone and not deprecate it 9.x..
Going to leave as RTBC against 9.x and get release manager opinion.
Comment #16
catchI think we can just mark this fixed for 10.0.x, dead code removal is a good major release thing.