I enabled the module then I go to edit some content. I highlight the text that I am wanting to use and hit the button and I am only prompted with a box that wants the source url. Then once I enter something below the content I highlighted I see a From, Source Title that is within tags. Am I missing something or can someone buy me a clue?

Thanks in advance.

CommentFileSizeAuthor
#2 3293951-use-cite-text.patch2.01 KBmjpa

Comments

Christopher Riley created an issue. See original summary.

mjpa’s picture

mjpa commented
Status: Active » Needs review
StatusFileSize
new 3293951-use-cite-text.patch2.01 KB

The plugin has the "From, Source title" hard coded for some reason. I've attached a patch that:

1. Uses the source text you enter for the figcaption
2. Doesn't wrap it in a cite element or create a cite attribute so you control the exact text
3. Change the dialog to use "Source" as a label, "Source URL" is confusing as it doesn't need to be a URL

  • cae203b3 committed on 8.x-1.x 
    Issue #3293951 by christopher-riley Use source text as default caption.

  • 9ae6a626 committed on 8.x-1.x 
    Issue #3293951 by mjpa, Christopher Riley: Update README."

git commit -...
alxp’s picture

alxp commented

This patch works and makes sense to me. Sorry for the delay, I don't use this module at my current workplace and had to set up my dev environment.

alxp’s picture

alxp commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.