Problem/Motivation

When forms_steps_entity_predelete is triggered it gets workflow entities by adding only entity_id condition to the entity query. Different types of entities may have the same ids, which may cause deleting of wrong workflow: e.g. you are deleting user with id 1. forms_steps_entity_predelete may select node with id 1 instead of user.

Proposed resolution

We should also check by entity_type to ensure that we are not deleting other worflows.

CommentFileSizeAuthor
#6 forms_steps-db-query-conditions-3293823-4.patch595 bytesjuliengui
#3 forms_steps-db-query-conditions-3293823-3.patch907 bytesid.aleks

Issue fork forms_steps-3293823

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

id.aleks created an issue. See original summary.

id.aleks opened merge request !6

id.aleks’s picture

id.aleks commented
Assigned: id.aleks » Unassigned
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new forms_steps-db-query-conditions-3293823-3.patch907 bytes

I'm attaching the patch based on MR. Also, I'm changing the priority to critical because this issue causes data loss.

juliengui’s picture

juliengui commented

Issue need rebase

Julien' changed the visibility of the branch 3293823-formsstepsentitypredelete-deletes-wrong-rebase to hidden.

juliengui’s picture

juliengui commented
StatusFileSize
new forms_steps-db-query-conditions-3293823-4.patch595 bytes

Add patch file for version 1.5

kbriand’s picture

kbriand commented
Status: Needs review » Reviewed & tested by the community

Patch #6 works.

nicoloye’s picture

nicoloye commented
Status: Reviewed & tested by the community » Fixed

Thanks for the good work!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • 4ce0d905 committed on 8.x-1.x 
    fix: #3293823 forms_steps_entity_predelete deletes wrong workflows

By:...