Problem/Motivation

The changes introduced in #3283956: Workspace config: Config leaking from one workspace into others caused some followup problems like 1. the deployment of workspace config got broken and 2. the leaking listing of configs was fixed, but the reading/loading wasn't likewise.

Steps to reproduce

On Vanilla Drupal 9

  1. Enable wse_config
  2. Switch to the stage workspace
  3. Change the content view, for example by adding something in the header and save it
  4. Switch to Live and observe the change being loaded whereas it shouldn't
  5. Publish the stage workspace and observer how the change in the view is not applied in live

Proposed resolution

Instead of using the post publish hook, we need to sync config already in the pre publish event, as in the post publish hook we can't list the config changed inside the workspace anymore because at that point it is already deployed.

Also add the workspace field to all entity queries in the wse config storage to ensure the queries only return config actually relevant to the current workspace.

Issue fork wse-3293755

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

s_leu created an issue. See original summary.

s_leu’s picture

Status: Active » Needs review
amateescu’s picture

Status: Needs review » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

amateescu’s picture

Component: Code » Workspace Config