FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\route_decorator\README.txt
----------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 140 characters
----------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\route_decorator\route_decorator.services.yml
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
11 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\route_decorator\src\Controller\DecoratingController.php
---------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\route_decorator\src\EventSubscriber\DecorationRouteSubscriber.php
-------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\route_decorator\src\Routing\RouteEnhancement.php
--------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
33 | ERROR | [ ] Type hint "array" missing for $defaults
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\route_decorator\tests\modules\route_decoration_revisions_test\src\Controller\NodeVersionHistoryDecorator.php
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
--------------------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\route_decorator\tests\modules\route_decorator_test\src\Controller\DecorationTestController.php
------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
20 | WARNING | [x] A comma should follow the last multiline array item. Found: ]
------------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: C:\xampp_new\htdocs\contribute\web\modules\custom\route_decorator\tests\src\Kernel\RouteDecorationTest.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
35 | WARNING | [x] 'TODO: assert content.' should match the format '@todo Fix problem X here.'
38 | WARNING | [x] There must be no blank line following an inline comment
38 | WARNING | [x] 'TODO: Add test for route_decoration_revisions_test module.' should match the format '@todo Fix problem X here.'
-------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------------

Comments

Harsh panchal created an issue. See original summary.

Harsh panchal’s picture

Category: Task » Bug report
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new2.77 KB

I have fixed this issue and providing a patch.

joachim’s picture

Status: Needs review » Fixed

Thanks for the patch!

I'm leaving out this one:

> 33 | ERROR | [ ] Type hint "array" missing for $defaults

as I think we should match what the parent method does.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.