FILE: /var/www/html/drupal9/modules/contrib/colorapi/src/Form/ConfigForm.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------------------------------
126 | WARNING | [ ] Unused variable $sring.
143 | WARNING | [x] '@todo - Find a less nuclear option, ideally invalidating cache tags.' should match the format '@todo Fix problem X here.'
------------------------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9/modules/contrib/colorapi/src/Plugin/Field/FieldFormatter/ColorapiRawHexDisplayFormatter.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
58 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9/modules/contrib/colorapi/src/Plugin/Field/FieldFormatter/ColorapiTextDisplayFormatter.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
39 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9/modules/contrib/colorapi/src/Plugin/Field/FieldWidget/ColorapiWidgetBase.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------------------
34 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------

FILE: /var/www/html/drupal9/modules/contrib/colorapi/src/Plugin/Field/FieldType/ColorItem.php
---------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
85 | ERROR | [x] Use null coalesce operator instead of ternary operator.
87 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#3 Drupal-coding-standard-3293566-3.patch3.92 KBatul_ghate

Issue fork colorapi-3293566

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

atul ghate created an issue. See original summary.

atul_ghate’s picture

atul_ghate commented
Assigned: Unassigned » atul_ghate

i will work on that issue

atul_ghate’s picture

atul_ghate commented
StatusFileSize
new Drupal-coding-standard-3293566-3.patch3.92 KB

Hi,
here is a patch for this issue, please review.

atul_ghate’s picture

atul_ghate commented
Assigned: atul_ghate » Unassigned
Status: Active » Needs review

Indra patil made their first commit to this issue’s fork.

indrapatil’s picture

indrapatil commented
Status: Needs review » Reviewed & tested by the community

Hi
I have reviewed it and the patch and it looks fine.
Moving to RTBC

neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Version: 8.x-1.2 » 8.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

@atul ghate you had commented $sring, but should have been $string, so fixed in commit. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.