Problem/Motivation

FILE: C:\xampp\htdocs\test\web\modules\contrib\disable_inline_form_errors\src\Form\DisableInlineFormErrors.php
--------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------
8 | ERROR | Doc comment is empty
29 | ERROR | Missing short description in doc comment
--------------------------------------------------------------------------------------------------------------

Time: 374ms; Memory: 8MB

CommentFileSizeAuthor
#2 php-drupal-standard-3293555-2.patch640 bytesashutosh ahirwal

Issue fork disable_inline_form_errors-3293555

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ashutosh Ahirwal created an issue. See original summary.

ashutosh ahirwal’s picture

ashutosh ahirwal commented
Assigned: ashutosh ahirwal » Unassigned
Status: Needs work » Needs review
StatusFileSize
new php-drupal-standard-3293555-2.patch640 bytes

Providing patch.
Need review.

urvashi_vora’s picture

urvashi_vora commented
Assigned: Unassigned » urvashi_vora

I will review this.

urvashi_vora’s picture

urvashi_vora commented
Assigned: urvashi_vora » Unassigned
Status: Needs review » Reviewed & tested by the community

Hi @Ashutosh,

I reviewed the patch. It applied cleanly.

urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib/disable_inline_form_errors-3293555$ git apply -v php-drupal-standard-3293555-2.patch
Checking patch src/Form/DisableInlineFormErrors.php...
Applied patch src/Form/DisableInlineFormErrors.php cleanly.

And I can confirm that now no other issues are there. 

urvasi@urvasi-Inspiron-15-3552:/var/www/html/contribution/d8_cont/web/modules/contrib$ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig disable_inline_form_errors-3293555/

Moving it to RTBC, and creating an MR.

Thanks

urvashi_vora opened merge request !1

rksyravi made their first commit to this issue’s fork.

rksyravi’s picture

rksyravi
Primary language Hindi
Location New Delhi, 🇮🇳
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: -

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.