Problem/Motivation

  • Correct problems detected by the code inspector

Issue fork cloud-3293499

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ryo Yamashita created an issue. See original summary.

Ryo Yamashita opened merge request !1148

ryo yamashita’s picture

ryo yamashita commented
Status: Needs work » Needs review

@yas

I modified the following elements.

  • Fix equal ampersand operator
  • Fix typo and grammatical error
  • Fix "Undefined symbols group" inspection
  • Fix "Probable bugs" inspection
  • Fix "Unused symbols group" inspection
  • Fix "Type compatibility group" inspection

Please review it. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Fix minor remarks about Cloud module » Refactor Drupal\aws_cloud\Controller\Ec2\ApiControllerInterface, Drupal\aws_cloud\Service\AwsCloud\AwsCloudOperationsServiceInterface, Drupal\openstack\Service\OpenStackOperationsService and more
Issue summary: View changes
Status: Needs review » Needs work

@ryo-yamashita

Thank you for the refactoring. It looks good. I posted my comments. Could you please check them?

Thanks!

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community

@ryo-yamashita

Thank you for the update. The patch looks good to me. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 041b252 on 5.x authored by Ryo Yamashita 
    Issue #3293499 by Ryo Yamashita, yas: Refactor Drupal\aws_cloud\...

  • yas committed 83d7994 on 4.x authored by Ryo Yamashita 
    Issue #3293499 by Ryo Yamashita, yas: Refactor Drupal\aws_cloud\...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.