Problem/Motivation

Several test cases refer to Simpletest, but we have now migrated to PHPUnit.

Steps to reproduce

Proposed resolution

Replace or remove the references.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3293216

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

longwave created an issue. See original summary.

longwave opened merge request !2448

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Assigned: Unassigned » longwave
Status: Active » Needs work
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Nice this will help us not have to think as much. +1

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs work » Needs review

quietone made their first commit to this issue’s fork.

spokje’s picture

spokje
Primary language Dutch
commented

I like this clean up :)

One thing that I've noticed is that, if I grep the codebase with the MR applied, there's still a lot of references left.

I've already incorporated the fact that we (most probably) can't rename the test-output folder from sites/simpletest to something else without starting The Apocalypse.

Also (almost?) all of the references are in comments or doc-blocks, so maybe that's something for a follow-up?

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

I left anything to do with the sites/simpletest directory or the prefixed environment variables (which I think have to be handled in separate issues). I probably missed some references in comments that still could be cleaned up, happy to have another pass at those.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

Removed another 40 or so references, mostly from comments.

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: longwave » Unassigned
Status: Needs review » Reviewed & tested by the community

Took me a while to finally get back to reviewing this one. Sorry about that.

All looks great, so this is RTBC for me.

  • catch committed b0cb325 on 10.0.x 
    Issue #3293216 by longwave, Spokje, quietone: Rename references to...
  • catch committed ebe774d on 10.1.x
    Issue #3293216 by longwave, Spokje, quietone: Rename references to...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

I grepped for simpletest with this applied, and still found a dozen or so references, however this is a big improvement, so let's open a follow-up to remove the remaining stragglers.

Committed/pushed to 10.1.x and cherry-picked to 10.0.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.