Problem/Motivation

Need to open the external URL in to the new tab.

Steps to reproduce

  1. Goto to Configuration page /admin/config/development/launch-checklist
  2. Open any of the links under the tab
  3. If module has been installed, link take to the Configuration page
  4. Else, It will open module download page

Proposed resolution

Open all external links into new tab. So, user will not loss their configuration settings values.
['attributes' => ['target' => '_blank']]

Remaining tasks

Testing

User interface changes

Nil

API changes

Nil

Data model changes

Nil

CommentFileSizeAuthor
#2 External-url-new-tab-3292866-2.patch27.21 KBarunkumark

Issue fork launch_checklist-3292866

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

arunkumark created an issue. See original summary.

arunkumark’s picture

arunkumark
Location Coimbatore
commented
Status: Active » Needs review
StatusFileSize
new External-url-new-tab-3292866-2.patch27.21 KB
stockfoot’s picture

stockfoot commented

I am beginning the review of this task

stockfoot’s picture

stockfoot commented

The patch has been tested via GitPod and locally using Drupal 9.
I have confirmed that the patch meets the acceptance criteria, as well as meeting PHP coding standards.

stockfoot’s picture

stockfoot commented
Status: Needs review » Reviewed & tested by the community
stockfoot’s picture

stockfoot commented
Assigned: arunkumark » Unassigned

Stockfoot opened merge request !3

stockfoot’s picture

stockfoot commented

We were unable to apply the patch successfully on 1.x-dev.
I have re-rolled the patch into a GitLab merge request that is ready to go.

https://git.drupalcode.org/project/launch_checklist/-/merge_requests/3

stockfoot’s picture

stockfoot commented

The issues have been corrected on the merge request.
This is now ready for review again

stockfoot’s picture

stockfoot commented
Status: Reviewed & tested by the community » Needs review
echechulina’s picture

echechulina commented
Status: Needs review » Needs work

I've tested your code locally, all links where you added the $attr work well and open in a New Tab, except this one: Site User Roles. You can find it in the User Permissions tab. At the same time, I think that Site User Roles is not an external link.

stockfoot’s picture

stockfoot commented
Status: Needs work » Needs review

Thank you Elena, I have removed the external link attribute from the "Site User Roles" link that exists on the Permission tab.

This is now ready for review again

echechulina’s picture

echechulina commented
Status: Needs review » Reviewed & tested by the community

Everything works well and looks good!

thejimbirch’s picture

thejimbirch commented
Status: Reviewed & tested by the community » Fixed

Merging, thank all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.