Problem/Motivation

Because of #3083275: [meta] Update tests that rely on Classy to not rely on it anymore and Classy being deprecated in Drupal 9 + removed in Drupal 10,: Tests that aren't specifically testing Classy yet declare $defaultTheme = 'classy'; should be refactored to use Stark as the default theme instead.

The Field Layout module is slated for removal from core, but that is not going to happen before D10. For some details and background see the meta: #3007167: [policy] Deprecate field_layout module and move it to contrib

Proposed resolution

Change all tests in this module to use Stark as the default theme, and refactor the tests where needed so they continue to function properly.

CommentFileSizeAuthor
#2 3292560-2.patch4.84 KBdanflanagan8

Comments

danflanagan8 created an issue. See original summary.

danflanagan8’s picture

Assigned: danflanagan8 » Unassigned
Status: Active » Needs review
StatusFileSize
new4.84 KB

Here's a patch

danflanagan8’s picture

Issue summary: View changes
smustgrave’s picture

Rerunning the tests

But searched field_layout folder for classy and nothing returned so I'll mark RTBC after the tests.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

  • lauriii committed b7b2437 on 10.1.x
    Issue #3292560 by danflanagan8, smustgrave: Field Layout tests should...

  • lauriii committed 11c70ed on 10.0.x
    Issue #3292560 by danflanagan8, smustgrave: Field Layout tests should...
lauriii’s picture

Status: Reviewed & tested by the community » Fixed

Committed b7b2437 and pushed to 10.1.x and cherry-picked to 10.0.x and 9.5.x. Thanks!

  • lauriii committed 0f3708a on 9.5.x
    Issue #3292560 by danflanagan8, smustgrave: Field Layout tests should...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.