FILE: C:\xampp\htdocs\test\web\modules\custom\custom_page_title\custom_page_title.install
-----------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
10 | ERROR | [x] There must be no blank lines after the function comment
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------
FILE: C:\xampp\htdocs\test\web\modules\custom\custom_page_title\custom_page_title.module
----------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
24 | ERROR | [x] Expected 1 blank line after function; 2 found
37 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
50 | WARNING | [ ] Only string literals should be passed to t() where possible
----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------
FILE: C:\xampp\htdocs\test\web\modules\custom\custom_page_title\src\Form\CustomPageTitleSettingsForm.php
----------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 11 LINES
----------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
16 | ERROR | [ ] Missing member variable doc comment
17 | ERROR | [ ] Missing member variable doc comment
75 | ERROR | [x] Expected one space after the comma, 0 found
76 | ERROR | [x] Expected one space after the comma, 0 found
121 | ERROR | [x] Use null coalesce operator instead of ternary operator.
130 | ERROR | [x] Use null coalesce operator instead of ternary operator.
139 | ERROR | [x] Use null coalesce operator instead of ternary operator.
151 | ERROR | [x] Use null coalesce operator instead of ternary operator.
170 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | updated-3291968-13.patch | 4.77 KB | jay jangid |
| #12 | Screenshot 2022-12-30 124722.png | 11.3 KB | dheeraj jhamtani |
| #9 | Screenshot_2.png | 45.71 KB | sagartiwari |
| #8 | Screenshot from 2022-06-23 17-28-37.png | 6.28 KB | akshaydalvi212 |
| #6 | phpcs-coding-standard-drupal-3291968-6.patch | 4.77 KB | Harsh panchal |
Issue fork custom_page_title-3291968
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
Harsh panchal commentedI have fixed this issue and providing a patch.
Comment #3
akshaydalvi212 commentedI will review the patch.
Comment #4
akshaydalvi212 commentedHi @Harsh panchal,
after applying the patch. most of the errors and warnings are eliminated, but the following warnings is still there:

can you update the patch for the remaining warnings.
Comment #5
Harsh panchal commentedHi @akshaydalvi212
I will fix this and applying a new patch. Thanks
Comment #6
Harsh panchal commentedI have fix this and providing a new patch.
Comment #7
akshaydalvi212 commentedi will review the updated patch.
Comment #8
akshaydalvi212 commentedHi,
After applying the updated patch, all the mentioned errors and warnings are eliminated from the files.

As the patch is good to go, hence switching the status of the issue to Reviewed and tested by the community.
Comment #9
sagartiwari commentedPatch applied successfully
Comment #10
Sonam Goswami commentedPatch #6 is applied succesfully on drupal 9 and drupal 10 and module version 1.0.x-dev and its working fine.
Thank you @Harsh panchal for the patch.
Comment #12
dheeraj jhamtani commentedHi @Harsh panchal,
after applying the patch. most of the errors and warnings are eliminated, but there are still one error.
Comment #13
jay jangid commentedKindly review this patch.
Thank you.
Comment #15
dheeraj jhamtani commentedComment #17
heni_deepak commented