FILE: C:\xampp\htdocs\test\web\modules\custom\custom_page_title\custom_page_title.install
-----------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-----------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
10 | ERROR | [x] There must be no blank lines after the function comment
-----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\test\web\modules\custom\custom_page_title\custom_page_title.module
----------------------------------------------------------------------------------------
FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
----------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
24 | ERROR | [x] Expected 1 blank line after function; 2 found
37 | ERROR | [x] Expected 1 space after FOREACH keyword; 0 found
50 | WARNING | [ ] Only string literals should be passed to t() where possible
----------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\test\web\modules\custom\custom_page_title\src\Form\CustomPageTitleSettingsForm.php
----------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AND 1 WARNING AFFECTING 11 LINES
----------------------------------------------------------------------------------------------------------------------
1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
13 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
16 | ERROR | [ ] Missing member variable doc comment
17 | ERROR | [ ] Missing member variable doc comment
75 | ERROR | [x] Expected one space after the comma, 0 found
76 | ERROR | [x] Expected one space after the comma, 0 found
121 | ERROR | [x] Use null coalesce operator instead of ternary operator.
130 | ERROR | [x] Use null coalesce operator instead of ternary operator.
139 | ERROR | [x] Use null coalesce operator instead of ternary operator.
151 | ERROR | [x] Use null coalesce operator instead of ternary operator.
170 | ERROR | [x] Use null coalesce operator instead of ternary operator.
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------------

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Harsh panchal created an issue. See original summary.

Harsh panchal’s picture

Category: Task » Bug report
Status: Active » Needs review
StatusFileSize
new4.25 KB

I have fixed this issue and providing a patch.

akshaydalvi212’s picture

I will review the patch.

akshaydalvi212’s picture

Assigned: akshaydalvi212 » Unassigned
Issue summary: View changes
Status: Needs review » Needs work
StatusFileSize
new29.12 KB

Hi @Harsh panchal,

after applying the patch. most of the errors and warnings are eliminated, but the following warnings is still there:

can you update the patch for the remaining warnings.

Harsh panchal’s picture

Hi @akshaydalvi212
I will fix this and applying a new patch. Thanks

Harsh panchal’s picture

Status: Needs work » Needs review
StatusFileSize
new4.77 KB

I have fix this and providing a new patch.

akshaydalvi212’s picture

Assigned: Unassigned » akshaydalvi212

i will review the updated patch.

akshaydalvi212’s picture

Assigned: akshaydalvi212 » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new6.28 KB

Hi,

After applying the updated patch, all the mentioned errors and warnings are eliminated from the files.

As the patch is good to go, hence switching the status of the issue to Reviewed and tested by the community.

sagartiwari’s picture

StatusFileSize
new45.71 KB

Patch applied successfully

Sonam Goswami’s picture

Patch #6 is applied succesfully on drupal 9 and drupal 10 and module version 1.0.x-dev and its working fine.
Thank you @Harsh panchal for the patch.

Dheeraj Jhamtani made their first commit to this issue’s fork.

dheeraj jhamtani’s picture

Status: Reviewed & tested by the community » Needs work
StatusFileSize
new11.3 KB

Hi @Harsh panchal,

after applying the patch. most of the errors and warnings are eliminated, but there are still one error.

jay jangid’s picture

Status: Needs work » Needs review
StatusFileSize
new4.77 KB

Kindly review this patch.
Thank you.

dheeraj jhamtani’s picture

Status: Needs review » Reviewed & tested by the community

heni_deepak’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.