FILE: C:\xampp\htdocs\contribution\web\modules\contrib\cloner\README.md
-----------------------------------------------------------------------
FOUND 0 ERRORS AND 9 WARNINGS AFFECTING 9 LINES
-----------------------------------------------------------------------
13 | WARNING | Line exceeds 80 characters; contains 87 characters
17 | WARNING | Line exceeds 80 characters; contains 181 characters
21 | WARNING | Line exceeds 80 characters; contains 95 characters
22 | WARNING | Line exceeds 80 characters; contains 99 characters
23 | WARNING | Line exceeds 80 characters; contains 99 characters
24 | WARNING | Line exceeds 80 characters; contains 120 characters
25 | WARNING | Line exceeds 80 characters; contains 105 characters
28 | WARNING | Line exceeds 80 characters; contains 410 characters
47 | WARNING | Line exceeds 80 characters; contains 190 characters
-----------------------------------------------------------------------

CommentFileSizeAuthor
#8 interdiff_6-8.txt436 bytesimmaculatexavier
#8 3291187-8.patch3.51 KBimmaculatexavier
#6 interdiff_4-6.txt411 bytessourabhjain
#6 3291187-6.patch3.51 KBsourabhjain
#4 interdiff_1-4.txt2.46 KBsourabhjain
#4 3291187-4.patch3.51 KBsourabhjain
#2 line_exceeds_80_characters-3291187-1.patch3.52 KBrakhi soni

Comments

Rakhi Soni created an issue. See original summary.

rakhi soni’s picture

rakhi soni commented
Assigned: rakhi soni » Unassigned
Status: Active » Needs review
StatusFileSize
new line_exceeds_80_characters-3291187-1.patch3.52 KB

I have created a patch with the phpcs Drupal Standard, please review.

sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Needs review » Needs work

I have reviewed the patch #2 and found the below issues:

FILE: /Users/sourabhjain/www/2022/drupal/modules/contrib/cloner/README.md
-------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
-------------------------------------------------------------------------
 42 | WARNING | Line exceeds 80 characters; contains 81 characters
 62 | WARNING | Line exceeds 80 characters; contains 82 characters
 63 | WARNING | Line exceeds 80 characters; contains 83 characters
-------------------------------------------------------------------------
sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3291187-4.patch3.51 KB
new interdiff_1-4.txt2.46 KB

I have resolved the above mentioned issue. Please review.

mrinalini9’s picture

mrinalini9 commented
Status: Needs review » Needs work

Hi,

I have reviewed patch #4, it applied cleanly and fixed all the warnings as mentioned above in the issue description.
But the below lines can be split up into two lines instead of three lines as per my observation:

+**Cloner**
+let you clone any entity on Drupal site, and provide forms for
+this as well.

So, moving this back to Needs Work.

Thanks & Regards,
Mrinalini

sourabhjain’s picture

sourabhjain
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 3291187-6.patch3.51 KB
new interdiff_4-6.txt411 bytes

I have resolved the above mentioned issue in #5. Please review.

mrinalini9’s picture

mrinalini9 commented
Status: Needs review » Needs work

Hi,

For splitting into two lines, I meant to say like this:

**Cloner** let you clone any entity on Drupal site, and provide forms for this
as well.

Please fix this.
So, moving this to Needs Work.

Thanks & Regards,
Mrinalini

immaculatexavier’s picture

immaculatexavier commented
Status: Needs work » Needs review
StatusFileSize
new 3291187-8.patch3.51 KB
new interdiff_6-8.txt436 bytes

Addressed #7. Attached the patch for the same.

mrinalini9’s picture

mrinalini9 commented

Hi,

Reviewed patch #8, looks good to me.

Thanks & Regards,
Mrinalini

niklan’s picture

niklan
Primary language Russian
Location Russia, Perm
commented
Status: Needs review » Fixed

Thank you folks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.