Problem/Motivation

  • Refactor the source code based on Drupal best practices

Issue fork cloud-3290795

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas opened merge request !1073

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review

@sekinet @masami @xiaohua-guan @ryo-yamashita

Could you please review the patch? Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Refactor the source code based on Drupal best practices (1) » Refactor the source code based on Drupal best practices (2) (Unused variable)
sekinet’s picture

sekinet commented

@yas

The patch looks good to me.
Thanks

ryo yamashita’s picture

ryo yamashita commented

@yas

The patch looks good to me. Thanks.

xiaohua guan’s picture

xiaohua guan commented

@yas

It looks good to me.

masami’s picture

masami commented

@yas
The patch looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@sekinet @ryo-yamashita @xiaohua-guan @masami

Thank you for your review. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed b823335 on 5.x 
    Issue #3290795 by yas, sekinet, Ryo Yamashita, Xiaohua Guan, Masami:...

  • yas committed fe06cc4 on 4.x 
    Issue #3290795 by yas, sekinet, Ryo Yamashita, Xiaohua Guan, Masami:...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.