Problem/Motivation
If a user does not have edit access to any menus shown on /admin/structure/domain-menus, all menus are shown here.
This does not make any sense, cause users cannot do anything here/ have no actions buttons.
This is based on the fact, that the filter logic in DomainMenusListBuilder will not work in case of empty $menus array - in this case the query will run without filtering.
Steps to reproduce
- Create some domains: Domain A, Domain B, Domain C
- Create some menus with following relations: Menu 1 -> Domain A, Domain B, Menu 2 -> Domain B
- Create a user with permission Edit active domain menus and associate it to Domain C
- Login to Domain C and open /admin/structure/domain-menus
- All available menus will be shown here
Proposed resolution
In case of having zero results in the filtering, the list of menus should be empty on /admin/structure/domain-menus.
Remaining tasks
I'll add a Merge Request in this issue, fixing the issue.
Comments
Comment #3
steffenrComment #4
steffenrComment #6
drpldrp commentedFixed in 3.4.1.
Comment #7
drpldrp commented