Problem/Motivation

Coding Standard issues are present.

Steps to reproduce

phpcs ./first_time_login --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml first_time_login/

FILE: /first_time_login/first_time_login.module
-----------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
-----------------------------------------------------------------------------
107 | WARNING | Only string literals should be passed to t() where possible
116 | WARNING | Only string literals should be passed to t() where possible
-----------------------------------------------------------------------------

FILE: /first_time_login/src/Form/FirstTimeLoginSettings.php
-----------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------
12 | WARNING | The class short comment should describe what the class does and not simply repeat the class name
-----------------------------------------------------------------------------------------------------------------

CommentFileSizeAuthor
#3 coding_standard_fixes-3287026-3.patch3.67 KBurvashi_vora

Issue fork first_time_login-3287026

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kuntal_d created an issue. See original summary.

urvashi_vora’s picture

urvashi_vora commented
Assigned: Unassigned » urvashi_vora

I am working on this

urvashi_vora’s picture

urvashi_vora commented
Assigned: urvashi_vora » Unassigned
Status: Active » Needs review
StatusFileSize
new coding_standard_fixes-3287026-3.patch3.67 KB

Hi @kuntal_d,
Please review this patch.

Thanks

kuntal_d’s picture

kuntal_d commented
Status: Needs review » Reviewed & tested by the community

Patch applied successfully and it solved the Coding standard issue.

urvashi_vora opened merge request !1

urvashi_vora’s picture

urvashi_vora commented

Hi @kuntal_d

Please check if you can merge this request.

Thanks

kuntal_d’s picture

kuntal_d commented

Hi @urvashi_vora,

I don't have access to merge.

  • urvashi_vora authored 0ff8fcb on 8.x-2.x 
    Issue #3287026: Coding Standard issues in first_time_login module
neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
commented
Status: Reviewed & tested by the community » Fixed

Thank you @urvashi_vora and @kuntal_d, I have merged the MR.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.