Add ckeditor5-stylesheets: false to Claro and Olivero (and fix it 😅)

Speaking as a theme maintainer and a person who works creating and maintaining themes for companies, I don't think it's a big deal to do a minor re-write of the styles assuming that we're just adjusting parent selectors or specificity.

99,9% of people going from Drupal 9>10 will be making at least some code changes, and changing around parent selectors isn't a big deal (even for backend devs), if they know they. need to do it.

That all being said, if we can get away with not having to do this one extra task, then that's that much easier and one less thing to worry about.

I mis-read that then. In that case, it probably makes sense to at least provide the basic typography rules (font, headings, etc).

it probably makes sense to at least provide the basic typography rules (font, headings, etc).

To clarify: do you mean Olivero's typography?

To clarify: do you mean Olivero's typography?

yeah 🤷‍♂️😆

I've spent a bit of time this morning thinking about how to bring in the styles without affecting the rest of the page. Looking through PostCSS Preset ENV tooling, I don't see anything that can do it. From what I understand the @apply rule is not on track for inclusion in native CSS and thus isn't in PostCSS Preset ENV.

We might need to have duplicate code, which kind of stinks. But at least we can then be very granular about what we want to include.

@mherchel AFAICT what @lauriii is proposing is to not make the markup edited & previewed through CKEditor 5 match the default front end theme, but just to give it sensible default typography.

Assigning to @lauriii for feedback.

I talked this over with @lauriii earlier today. I agree that it's not necessary to have the front-end styles within the admin WYSIWYG as long as the WYSIWYG styles visually convey the semantics of the text, which is the case with CK5.

Furthermore in many cases, it's actually desired since the WYSIWYG is smaller than the viewport and large text can look out of place.

I'm +1 on using the default CKEditor 5 styling vs bringing in default theme styles, but is the media-embed-error css something that should be provided in ckeditor5-stylesheets: since it's styling a UI component vs the actual editor content?

Thanks to #3304256: Remove Bartik from Drupal core, I don't think Bartik is a concern anymore.

That still leaves Claro & Olivero. Because we currently see this in the Text Formats & Editors UI:

+++ b/core/themes/claro/claro.info.yml
@@ -166,6 +166,8 @@ ckeditor_stylesheets:
+ckeditor5-stylesheets: false

+++ b/core/themes/olivero/olivero.info.yml
@@ -88,3 +88,5 @@ ckeditor_stylesheets:
+ckeditor5-stylesheets: false

These will be removed in #3270438: Remove CKEditor 4 from core, because there ckeditor_stylesheets will be removed as well!

So … 🚢!

Been hoping to see those messages go away for a while now, glad you spotted an issue & fixed it in the process. The test only patch makes it pretty clear that this is a good addition.

Merged to 10.1.x and cherry picked to 10.0.x and 9.5.x

The fix should still be backported to 9.4.x.

Will provide a patch. Currently not cleanly cherry-pickable. So determining what the optimal cherry-pick order is …

The #15 patch applies cleanly to 9.4.x — test running…

Hm, that failed unexpectedly 😢

The reason the #15 patch fails is that 9.5.x switched to Claro as the admin theme, and that was being used in the tests.

So all we have to do, is apply the pattern being applied here to Seven too in 9.4.x: indicate that there are no CKEditor 5 stylesheets for the Seven admin theme.

We need a clean patch for Drupal 9.5 version.