Problem/Motivation

Add a BDD test directory for OpenStack module and add the basic files

Issue fork cloud-3284370

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kumikoono created an issue. See original summary.

kumikoono opened merge request !1027

kumikoono’s picture

kumikoono commented
Status: Active » Needs review

@yas @s_niioka Can you review this?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@kumikoono

Thank you for supplying the patch. It looks good to me.

@shota-niioka

What do you think?

Thanks

shota niioka’s picture

shota niioka commented

@kumikoono @yas

It looks good to me !

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@shota-niioka

Thank you for your review. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 7989973 on 5.x authored by kumikoono 
    Issue #3284370 by kumikoono, yas, shota niioka: Add a BDD test directory...

  • yas committed 38f3462 on 4.x authored by kumikoono 
    Issue #3284370 by kumikoono, yas, shota niioka: Add a BDD test directory...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
kumikoono’s picture

kumikoono commented
Status: Fixed » Needs review

kumikoono opened merge request !1061

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@kumikoono

Thank you for the hotfix. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 31e19ab on 5.x authored by kumikoono 
    Issue #3284370 by kumikoono, yas: Hotfix - Add a BDD test directory for...

  • yas committed a2f470c on 4.x authored by kumikoono 
    Issue #3284370 by kumikoono, yas: Hotfix - Add a BDD test directory for...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.