Problem/Motivation

  • Refactor to update K8s resources

Issue fork cloud-3284108

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas opened merge request !1021

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review

@shota-niioka

Can you please test the patch? Thanks

xiaohua guan’s picture

xiaohua guan commented
Status: Needs review » Needs work

@yas

I posted my comment.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review

@xioahua-guan

Thank you for your review. I fixed the bug. Could you please review the patch again? Thanks

xiaohua guan’s picture

xiaohua guan commented

@yas

It looks good to me now.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

Thank you for your review!

shota niioka’s picture

shota niioka commented
Status: Needs review » Reviewed & tested by the community

@yas

I confirmed that some resource fixed.
Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@shota-niioka

Thank you for your review. I'll merge the patch to 4.x and 5.x after releasing 5.0.0-alpha2, and close this issue as Fixed.

  • yas committed 87bd62a on 5.x 
    Issue #3284108 by yas, Xiaohua Guan, shota niioka: Refactor to update...

  • yas committed 278b213 on 4.x 
    Issue #3284108 by yas, Xiaohua Guan, shota niioka: Refactor to update...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

@shota-niioka @xiaohua-guan

I found a bug. I'll create the hotfix. Thanks

yas opened merge request !1047

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community

@all

The tests have been passed successfully, I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed f1ba1b9 on 5.x 
    Issue #3284108 by yas: Hotfix - Refactor to update K8s resources

  • yas committed 51abac7 on 4.x 
    Issue #3284108 by yas: Hotfix - Refactor to update K8s resources
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Fixed » Needs work

@shota-niioka @xiaohua-guan

Sorry I found a bug again. I'll create the hotfix. Thanks

yas opened merge request !1048

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community

@all

The tests have been passed successfully, I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 0b9c32f on 5.x 
    Issue #3284108 by yas: Hotfix - Refactor to update K8s resources

  • yas committed 954842b on 4.x 
    Issue #3284108 by yas: Hotfix - Refactor to update K8s resources
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.