Issue fork cloud-3283947

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

onotm created an issue. See original summary.

onotm’s picture

onotm commented
Issue summary: View changes

onotm opened merge request !1018

onotm’s picture

onotm commented

@yas @ryo-yamashita Could you review the patch?

Why is it necessary to check if ec2Service is an instance of OpenStackEC2Service in the OpenStackInstanceStopForm?
How should that if statement be written in OpenStackOperationsService?

onotm’s picture

onotm commented
Status: Active » Needs review
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@onotm

Thank you for adding the SPA form.

@ryo-yamashita

What do you think?

Thanks

ryo yamashita’s picture

ryo yamashita commented

@yas

It looks good to me now. Thanks.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@ryo-yamashita

Thank you for your review.

@onotm

I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@onotm

I found the following coding standard violations. Could you please fix those?

FILE: ...rvice_providers/openstack/src/Form/OpenStackInstanceStopForm.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 18 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
FILE: ...e_providers/openstack/src/Service/OpenStackOperationsService.php
----------------------------------------------------------------------
FOUND 3 ERRORS AND 2 WARNINGS AFFECTING 4 LINES
----------------------------------------------------------------------
 372 | WARNING | [ ] Line exceeds 80 characters; contains 82
     |         |     characters
 375 | ERROR   | [x] Inline comments must start with a capital letter
 376 | ERROR   | [ ] Comment indentation error, expected only 1
     |         |     spaces
 377 | WARNING | [x] There must be no blank line following an inline
     |         |     comment
 377 | ERROR   | [x] Inline comments must end in full-stops,
     |         |     exclamation marks, question marks, colons, or
     |         |     closing parentheses
----------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 44.83 secs; Memory: 58.01MB
onotm’s picture

onotm commented
Status: Needs work » Needs review

@yas I fixed those errors and warnings and tested the patch. Could you review it?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@onotm

Thank you for fixing the coding standard violations. The patch looks good to me now. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

  • yas committed 1728a1d on 5.x authored by onotm 
    Issue #3283947 by onotm, yas, Ryo Yamashita: Add the function to stop...

  • yas committed 847a1c0 on 4.x authored by onotm 
    Issue #3283947 by onotm, yas, Ryo Yamashita: Add the function to stop...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.