ComposerHooksTest is broken on latest DrupalCI PHP container

I think our tests would also be broken with composer 2.2.11 since the alias has also been removed there.

Committed/pushed to 10.0.x, cherry-picked to 9.5.x and 9.4.x

Leaving this patch to be ported for 9.3.x and tagging needs release manager review - because we always branch off the tag for security releases, committing to 9.3.x doesn't automatically help, but maybe we can tag an extra release or combine this change with the first security release... or something.

Here are the results from https://www.drupal.org/pift-ci-job/2395338:

Testing Drupal\Tests\Composer\Plugin\Scaffold\Functional\ComposerHookTest
E.                                                                  2 / 2 (100%)

Time: 00:03.128, Memory: 4.00 MB

There was 1 error:

1) Drupal\Tests\Composer\Plugin\Scaffold\Functional\ComposerHookTest::testComposerHooks
RuntimeException: Exit code: 2

For additional security you should declare the allow-plugins config with a list of packages names that are allowed to run code. See https://getcomposer.org/allow-plugins
You have until July 2022 to add the setting. Composer will then switch the default behavior to disallow all plugins.
./composer.json has been updated
Running composer update fixtures/drupal-assets-fixture fixtures/scaffold-override-fixture
Loading composer repositories with package information
Updating dependencies
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - Root composer.json requires fixtures/drupal-assets-fixture dev-master, found fixtures/drupal-assets-fixture[dev-main] but it does not match the constraint. Perhaps dev-master was renamed to dev-main?
  Problem 2
    - Root composer.json requires fixtures/scaffold-override-fixture dev-master, found fixtures/scaffold-override-fixture[dev-main] but it does not match the constraint. Perhaps dev-master was renamed to dev-main?
  Problem 3
    - Root composer.json requires fixtures/drupal-core-fixture * -> satisfiable by fixtures/drupal-core-fixture[dev-main].
    - fixtures/drupal-core-fixture dev-main requires fixtures/drupal-assets-fixture * -> found fixtures/drupal-assets-fixture[dev-main] but it conflicts with your root composer.json require (dev-master).

Use the option --with-all-dependencies (-W) to allow upgrades, downgrades and removals for packages currently locked to specific versions.

Installation failed, reverting ./composer.json and ./composer.lock to their original content.

It looks as though the problem is a result of renaming master to main ... in the fixtures? The patch in #2 updates the test to use main, which seems like the right fix.

I do not see how this relates to the composer or PHP version. Did composer previously guess at this renaming or is the composer version a red herring? I get the same results (with and without the patch) locally with composer 2.3.5 and PHP 8.1.5.

+1 for RTBC, although I still have questions.

@alexpott:

I think I was ambiguous:

I get the same results (with and without the patch) locally with composer 2.3.5 and PHP 8.1.5.

What I meant was:

• With the patch, I get the same results locally (with composer 2.3.5 and PHP 8.1.5) as the testbot.
• Without the patch, I get the same results locally (with composer 2.3.5 and PHP 8.1.5) as the testbot.

All good?

Just for fun (since DDev makes it so easy) I installed composer 2.3.2 and confirmed that the test passes with 94b5d57502.

Earlier, I looked at the link in #2, but I missed that it was a change introduced in 2.3.3. I assume it is this one:

Removed dev-master=>dev-main alias from #10372 as it does not work when reloading from lock file and extracting dev deps (#10651)

Discussed the @xjm, last time we left the commit on the dev branch and included it in the release, so normal backporting is useful after all. Cherry-picked to 9.3.x too.