The current doc says:

"Collects JOIN and WHERE statements via hook_sql"

It seems it should say:

"Collects JOIN and WHERE statements via hook_db_rewrite_sql" instead, and link to hook_db_rewrite_sql

This fix is needed on both:
http://drupaldocs.org/api/4.6/function/_db_rewrite_sql
and
http://drupaldocs.org/api/head/function/_db_rewrite_sql

CommentFileSizeAuthor
#6 database.inc_4.patch616 bytesfgm
#5 database.inc_3.patch616 bytesfgm
#4 database.inc_2.patch605 bytesfgm

Comments

sepeck’s picture

sepeck commented
Status: Active » Closed (fixed)

drupaldocs has been decommed.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Closed (fixed) » Active

Error is still there on API:

http://api.drupal.org/api/HEAD/function/_db_rewrite_sql
http://api.drupal.org/api/4.7/function/_db_rewrite_sql
http://api.drupal.org/api/4.6/function/_db_rewrite_sql

All mention the nonexistent hook_sql

pwolanin’s picture

pwolanin commented

everyone who has CVS access can commit changes to the developer docs- so just check them out, change and commit. There's no real need to post an issue if you find an obvious error like this.

$ cvs co contributions/docs/developer

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new database.inc_2.patch605 bytes

This is not in the docs, but in core, which I'm not even able to commit to. Here are the three patches, for 4.6, 4.7 and HEAD.

First HEAD.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new database.inc_3.patch616 bytes

Now 4.7

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Active » Needs review
StatusFileSize
new database.inc_4.patch616 bytes

And finally 4.6.

pwolanin’s picture

pwolanin commented
Project: Documentation » Drupal core
Version: » 5.x-dev
Component: Developer Guide » database system

oh, yes- sorry. However, in that case the issue needs to be against Drupal, since otherwise the changes to the code comments will never be noticed and read by the core committers.

pwolanin’s picture

pwolanin commented
Status: Needs review » Reviewed & tested by the community

this is trivial and should be committed ASAP

drumm’s picture

drumm
he/him
Location NY, US
commented
Version: 5.x-dev » 6.x-dev

Committed to 5.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to all branches. :)

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)