Problem/Motivation

  • Refactor to trail whitespace at the end of line

Issue fork cloud-3282386

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas opened merge request !993

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Needs review

@kumikoono @ryo-yamashita @shota-niioka

Could you please review the patch? Thanks!

shota niioka’s picture

shota niioka commented

@yas

This patch looks good to me.
Thanks!

ryo yamashita’s picture

ryo yamashita commented

@yas

I can see this patch well too. Thanks!

kumikoono’s picture

kumikoono commented

This looks good to me. Out of curiosity, is there any checker to find these whitespaces?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@shota-niioka @ryo-yamashita @kumikoono

Thank you for your review. I'll merge the patch to 4.x and 5.x, and close this issue as Fixed.

@kumikoono

I bet that phpcs checks whitespaces at end of line only for PHP, JS and CSS. .tsx, .md, and .feature files are out of scope. So I recommend always to use the functionality of automatic code format on your IDE.

Thanks

  • yas committed 49fa80f on 5.x 
    Issue #3282386 by yas, shota niioka, Ryo Yamashita, kumikoono: Refactor...

  • yas committed d9747d0 on 4.x 
    Issue #3282386 by yas, shota niioka, Ryo Yamashita, kumikoono: Refactor...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.