Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Issue fork drupal-3281755

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake created an issue. See original summary.

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented

All test jobs currently failing on the commit check step.

mondrake opened merge request !2303

mondrake’s picture

mondrake
Location 🇮🇹
CreditAttribution: mondrake commented
Status: Active » Needs review
quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

Looking at the test results, the failing one are Nightwatch tests.

Locally, I ran phpstan on HEAD and got the error, applied the MR and ran phpstan again and no error.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Acro Commerce, Thunder commented
Status: Reviewed & tested by the community » Fixed

So here's an interesting advantage of the partial checks... partial checks mean that PHPStan doesn't break everything.

Committed b942103 and pushed to 10.0.x. Thanks!

  • alexpott committed b942103 on 10.0.x 
    Issue #3281755 by mondrake: PHPStan baseline broken again in head (...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mondrake closed merge request !2303