I've seen this issue several times, however I cannot reliably reproduce it.

The issue is that sometimes the browser displays a “ in place of the Left Double Quotation Mark .

I've seen this several (maybe 10ish) times over the past couple years, and I cannot reliably reproduce it. I generally use Chrome on MacOS, so I'm not sure if this is a Chrome thing, Mac thing, or something else entirely.

When this happens, reloading the page in the browser will fix it.

Fixing it

We cannot accurately reproduce this, but we can add the decoration in another way that will hopefully sidestep this bug:

We currently do a content: "“"; at https://git.drupalcode.org/project/drupal/-/blob/10.0.x/core/themes/oliv...

I propose we add the quote using its unicode characters (see https://unicode-table.com/en/201C/). This would look like content: "\201c";

Testing

Since we cannot reliably reproduce the issue, testing would involve ensuring no regressions across supported browsers.

Comments

mherchel created an issue. See original summary.

mherchel’s picture

Issue summary: View changes
mherchel’s picture

Issue summary: View changes
sakthivel m’s picture

Status: Active » Needs review
StatusFileSize
new1018 bytes

#4 Please review the patch

pallavisk’s picture

StatusFileSize
new314.79 KB
new332.48 KB

Verified and tested patch#4 on drupal 9.4.x Patch applied successfully.

Testing Steps:
1. Install drupal 9.4.x version.
2. Apply the patch.
3. Clear cache and reload the page.
4. Observe the blockquote content to get the difference.

Testing result:
Blockquote before content replaced by content: "\201c";

Can be move to RTBC

Manibharathi E R’s picture

Patch #4 Applied successfully on Drupal 9.4.x.

mherchel’s picture

@Manibharathi E R - Thanks for the comment, but the fact that the tests pass indicate that the patch applies successfully. If you'd like to contribute, testing steps and screenshots are helpful.

arun velusamy’s picture

StatusFileSize
new87.11 KB
new89.45 KB

I have verified the patch #4 and tested it on Drupal version 9.4.x. The patch works fine and I have added the before and after screenshots for reference.

andy-blum’s picture

Status: Needs review » Reviewed & tested by the community

per #5 and #8 RTBC

andy-blum’s picture

StatusFileSize
new514 bytes

Drupal 10 version patch

andy-blum’s picture

StatusFileSize
new1.01 KB

Ignore #10. I forgot to compile the assets. This one should be good.

  • lauriii committed 3761178 on 10.1.x
    Issue #3281341 by andy-blum, Sakthivel M, pallavisk, mherchel: Olivero's...

  • lauriii committed 49b045a on 10.0.x
    Issue #3281341 by andy-blum, Sakthivel M, pallavisk, mherchel: Olivero's...

  • lauriii committed b322857 on 9.5.x
    Issue #3281341 by andy-blum, Sakthivel M, pallavisk, mherchel: Olivero's...

  • lauriii committed 6e884e3 on 9.4.x
    Issue #3281341 by andy-blum, Sakthivel M, pallavisk, mherchel: Olivero's...
lauriii’s picture

Status: Reviewed & tested by the community » Fixed

Committed #11 3761178 and pushed to 10.1.x and cherry-picked to 10.0.x. Also committed #4 b322857 and pushed to 9.5.x and cherry-picked to 9.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.